Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2090773003: Add ability to bind a different InterfaceRegistry/InterfaceProvider to an incoming Connection. (Closed)

Created:
4 years, 6 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ability to bind a different InterfaceRegistry/InterfaceProvider to an incoming Connection. R=rockot@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/27c937b377d8ed44900a5508cbcd6c8021e7d0cc Cr-Commit-Position: refs/heads/master@{#402076}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -38 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/connector.h View 1 chunk +10 lines, -0 lines 0 comments Download
M services/shell/public/cpp/interface_provider.h View 1 chunk +3 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/connection_impl.h View 2 chunks +20 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.cc View 3 chunks +20 lines, -15 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 1 chunk +19 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/interface_provider.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/shell_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/shell_connection.cc View 1 chunk +27 lines, -4 lines 0 comments Download
M services/shell/public/cpp/shell_client.h View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Ben Goodger (Google)
They say it don't be like it is, but it do. It turns out things ...
4 years, 6 months ago (2016-06-23 04:32:50 UTC) #3
Ken Rockot(use gerrit already)
Hate it. But as discussed offline, since this is a transient change and you can ...
4 years, 5 months ago (2016-06-24 17:53:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090773003/20001
4 years, 5 months ago (2016-06-26 04:15:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-26 05:56:58 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-26 05:58:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27c937b377d8ed44900a5508cbcd6c8021e7d0cc
Cr-Commit-Position: refs/heads/master@{#402076}

Powered by Google App Engine
This is Rietveld 408576698