Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2096643002: Eliminate MojoApplicationHost (Closed)

Created:
4 years, 6 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mah3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate MojoApplicationHost. This: - Changes RenderProcessHost, UtilityProcessHost & GpuProcessHost to use MojoChildConnection. - Makes ChildThread own a MojoShellConnection. - Makes ChildThread a ShellClient, currently implementing the two horrible methods that allow it to provide its own InterfaceRegistry. - Rolls in the Shell API changes that allow clients to provide their own InterfaceRegistries/Providers for this purpose. - Eliminates the per-process MojoShellConnection for renderers. R=rockot@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Patch Set 19 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+635 lines, -526 lines) Patch
M blimp/client/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/app/blimp_content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/image_decoder.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/task_management/providers/child_process_task.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/task_management/providers/web_contents/renderer_task.cc View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/renderer_resource.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -5 lines 0 comments Download
M components/web_cache/browser/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M components/web_cache/browser/DEPS View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M components/web_cache/browser/web_cache_manager.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/battery_status/battery_monitor_integration_browsertest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 7 chunks +21 lines, -7 lines 0 comments Download
M content/browser/mojo/constants.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/mojo/constants.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
D content/browser/mojo/mojo_application_host.h View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D content/browser/mojo/mojo_application_host.cc View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 7 chunks +31 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 10 chunks +52 lines, -41 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 3 4 5 1 chunk +13 lines, -7 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 7 chunks +21 lines, -7 lines 0 comments Download
M content/browser/utility_process_host_impl_browsertest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/background_sync/background_sync_provider.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +14 lines, -11 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +31 lines, -10 lines 0 comments Download
D content/child/mojo/mojo_application.h View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D content/child/mojo/mojo_application.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -45 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M content/content.gyp View 1 chunk +28 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_resources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
A content/public/app/mojo/content_gpu_manifest.json View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A content/public/app/mojo/content_utility_manifest.json View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 2 chunks +12 lines, -4 lines 0 comments Download
M content/public/browser/browser_child_process_host_delegate.h View 2 chunks +12 lines, -2 lines 0 comments Download
M content/public/browser/browser_child_process_host_delegate.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M content/public/browser/gpu_service_registry.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/browser/gpu_service_registry.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/render_process_host.h View 3 chunks +9 lines, -3 lines 0 comments Download
M content/public/browser/utility_process_host.h View 3 chunks +15 lines, -5 lines 0 comments Download
M content/public/browser/utility_process_mojo_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/public/child/child_thread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +19 lines, -0 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/renderer/render_thread.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/mus/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -20 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.h View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_process_control_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M services/shell/public/cpp/connector.h View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M services/shell/public/cpp/interface_provider.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/connection_impl.h View 1 2 3 4 5 6 7 2 chunks +20 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.cc View 1 2 3 4 5 6 7 3 chunks +20 lines, -15 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 1 2 3 4 5 6 7 1 chunk +19 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/interface_provider.cc View 1 2 3 4 5 6 7 1 chunk +9 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/shell_client.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/shell_connection.cc View 1 2 3 4 5 6 7 1 chunk +27 lines, -4 lines 0 comments Download
M services/shell/public/cpp/shell_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (10 generated)
Ben Goodger (Google)
4 years, 6 months ago (2016-06-24 18:22:21 UTC) #11
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-06-24 21:34:16 UTC) #12 
Naming is much better than before. LGTM

Powered by Google App Engine
This is Rietveld 408576698