Do not CreateSentinel until after the process singleton has been grabbed by the current process.

Do not CreateSentinel until after the process singleton has been grabbed by the current process.

Move first_run::CreateSentinel to first_run::internal::CreateSentinel.

This is based on top of https://codereview.chromium.org/20483002/

BUG=264694
TEST= 
A) Launch chrome.exe with no First Run sentinel, make sure first run happens once (relaunch and it shouldn't happen twice). 
B) Launch chrome.exe with First Run sentinel, but with --force-first-run, make sure first run happens anyways. 
C) Launch chrome.exe with no First Run sentinel, but with --no-first-run, make sure first run doesn't happen (and doesn't happen in subsequent relaunches either without the flag).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214709

[gab, 2013-07-26 15:52:54]

Carlos, please take a look after looking @
https://codereview.chromium.org/20483002/.

Cheers!
Gab

[gab, 2013-07-29 17:45:44]

On 2013/07/26 15:52:54, gab wrote:
> Carlos, please take a look after looking @
> https://codereview.chromium.org/20483002/.
> 
> Cheers!
> Gab

ping following https://codereview.chromium.org/20483002/

Thanks!
Gab

[cpu_(ooo_6.6-7.5), 2013-07-30 18:15:40]

lgtm

[gab, 2013-07-30 18:26:30]

Thanks,

@Nico for OWNER.

Cheers,
Gab

[Nico, 2013-07-30 19:23:44]

+bauerb since this is removing some of his TODOs.

lgtm stamp based on cpu's review from me

[gab, 2013-07-30 19:53:04]

Thanks, TBR bauerb, basically it seems like you wanted to force --skip-first-run
instead of creating the sentinel in the tests to force no first run.

It turns out browser tests automatically specify --skip-first-run (in
test_launcher_utils.cc) -- I don't know if there is a time where this wasn't the
case, but it has been the case for quite a long time.

So unless your test explicitly adds --force-first-run to the command-line, it
will never go through the first run flow.

Cheers!
Gab

[Bernhard Bauer, 2013-07-30 22:40:16]

Awesome, LGTM!

[commit-bot: I haz the power, 2013-07-31 02:51:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/20743002/37001

[commit-bot: I haz the power, 2013-07-31 03:17:25]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-07-31 12:17:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/20743002/37001

[commit-bot: I haz the power, 2013-07-31 13:40:16]

Change committed as 214709