Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: chrome/browser/first_run/first_run.h

Issue 20743002: Do not CreateSentinel until after the process singleton has been grabbed by the current process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge latest version of https://codereview.chromium.org/20483002/ Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run/first_run.h
diff --git a/chrome/browser/first_run/first_run.h b/chrome/browser/first_run/first_run.h
index 4d1628c4427f9d029c602aff73cdf19f3944dd4b..a548bbf41a7658367ecc705e0c7f5d2e232b362c 100644
--- a/chrome/browser/first_run/first_run.h
+++ b/chrome/browser/first_run/first_run.h
@@ -91,8 +91,10 @@ struct MasterPrefs {
// Returns true if this is the first time chrome is run for this user.
bool IsChromeFirstRun();
-// Creates the sentinel file that signals that chrome has been configured.
-bool CreateSentinel();
+// Creates the first run sentinel if needed. This should only be called after
+// the process singleton has been grabbed by the current process
+// (http://crbug.com/264694).
+void CreateSentinelIfNeeded();
// Get RLZ ping delay pref name.
std::string GetPingDelayPrefName();
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698