get genmipmap function in the struct

get genmipmap function in the struct

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10393

[bsalomon, 2013-07-25 19:16:49]

https://codereview.chromium.org/20436002/diff/1/src/gpu/gl/GrGLInterface.cpp
File src/gpu/gl/GrGLInterface.cpp (right):

https://codereview.chromium.org/20436002/diff/1/src/gpu/gl/GrGLInterface.cpp#...
src/gpu/gl/GrGLInterface.cpp:81: NULL == fGenerateMipmap ||
I think Chrome needs to be protected from this line or else Ganesh will start
failing to initialize in Chrome.

[reed1, 2013-07-25 21:24:36]

https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
include/gpu/GrTexture.h:47: void dirtyMipMaps(bool mipMapsDirty) {
Do these need to be public? Seems like an easy way for a client to say the wrong
thing.

[humper, 2013-07-25 21:31:18]

On 2013/07/25 21:24:36, reed1 wrote:
> https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
> File include/gpu/GrTexture.h (right):
> 
>
https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
> include/gpu/GrTexture.h:47: void dirtyMipMaps(bool mipMapsDirty) {
> Do these need to be public? Seems like an easy way for a client to say the
wrong
> thing.

I think so; they're invoked by methods of the GrGPUGL class.  I could make a
friend
relationship if we really want to hide this.

[reed1, 2013-07-25 21:33:55]

On 2013/07/25 21:31:18, humper wrote:
> On 2013/07/25 21:24:36, reed1 wrote:
> > https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
> > File include/gpu/GrTexture.h (right):
> > 
> >
>
https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
> > include/gpu/GrTexture.h:47: void dirtyMipMaps(bool mipMapsDirty) {
> > Do these need to be public? Seems like an easy way for a client to say the
> wrong
> > thing.
> 
> I think so; they're invoked by methods of the GrGPUGL class.  I could make a
> friend
> relationship if we really want to hide this.

I defer to Brian

[bsalomon, 2013-07-25 21:36:58]

https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
include/gpu/GrTexture.h:167: bool                fMipMapsDirty;
need to init this in the cons to true, right?

[bsalomon, 2013-07-25 21:45:29]

On 2013/07/25 21:33:55, reed1 wrote:
> On 2013/07/25 21:31:18, humper wrote:
> > On 2013/07/25 21:24:36, reed1 wrote:
> > > https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
> > > File include/gpu/GrTexture.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
> > > include/gpu/GrTexture.h:47: void dirtyMipMaps(bool mipMapsDirty) {
> > > Do these need to be public? Seems like an easy way for a client to say the
> > wrong
> > > thing.
> > 
> > I think so; they're invoked by methods of the GrGPUGL class.  I could make a
> > friend
> > relationship if we really want to hide this.
> 
> I defer to Brian

I say ok for now.. we have some related stuff on GrRenderTarget we should hide
as well. We can do them together.

[humper, 2013-07-25 21:49:41]

On 2013/07/25 21:36:58, bsalomon wrote:
> https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h
> File include/gpu/GrTexture.h (right):
> 
>
https://codereview.chromium.org/20436002/diff/9001/include/gpu/GrTexture.h#ne...
> include/gpu/GrTexture.h:167: bool                fMipMapsDirty;
> need to init this in the cons to true, right?

Probably cleaner to initialize it, although any time any bits get set in the
texture, the flag is initialized to true, so this is probably just a cleanliness
thing.

[bsalomon, 2013-07-25 22:01:01]

On 2013/07/25 21:52:04, humper wrote:

lgtm

[bsalomon, 2013-07-25 22:01:08]

https://codereview.chromium.org/20436002/diff/23001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/20436002/diff/23001/include/gpu/GrTexture.h#n...
include/gpu/GrTexture.h:147: , fRenderTarget(NULL), fMipMapsDirty(true) {
style nit

: INHERITED(gpu, isWrapped, desc)
, fRenderTarget(NULL)
, fMipMapsDirty(true)

[commit-bot: I haz the power, 2013-07-26 16:28:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/20436002/30001

[commit-bot: I haz the power, 2013-07-26 16:36:07]

Change committed as 10393