Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 202983002: Make the safe Console singleton be const (Closed)

Created:
6 years, 9 months ago by sra1
Modified:
6 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make the safe Console singleton be const Partly addresses http://dartbug.com/17508 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=34052

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Console.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 9 months ago (2014-03-18 02:18:24 UTC) #1
Emily Fortuna
lgtm
6 years, 9 months ago (2014-03-18 04:55:50 UTC) #2
sra1
6 years, 9 months ago (2014-03-18 19:15:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698