sdk/lib/html/dart2js/html_dart2js.dart - Issue 202983002: Make the safe Console singleton be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 202983002: Make the safe Console singleton be const (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 82454e38792a675bb78e6030adc5a871deec3470..78f263828481a98e838047e30872e4917c91ec06 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -2261,9 +2261,9 @@ class CompositionEvent extends UIEvent native "CompositionEvent" {

@DomName('Console')

class Console {

- Console._safe() {}

+ const Console._safe();

- static Console _safeConsole = new Console._safe();

+ static const Console _safeConsole = const Console._safe();

bool get _isConsoleDefined => JS('bool', 'typeof console != "undefined"');

@@ -2289,7 +2289,7 @@ class Console {

@DomName('Console.dir')

void dir(Object arg) => _isConsoleDefined ?

- JS('void', 'console.debug(#)', arg) : null;

+ JS('void', 'console.dir(#)', arg) : null;

@DomName('Console.dirxml')

void dirxml(Object arg) => _isConsoleDefined ?

« no previous file with comments | « no previous file | tools/dom/templates/html/dart2js/impl_Console.darttemplate » ('j') | no next file with comments »