Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/browser/resources/md_history/history_list.html

Issue 1972073002: [MD History] Make history-list:historyData private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_loading
Patch Set: oopz Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_list.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-scroll-threshold/i ron-scroll-threshold.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-scroll-threshold/i ron-scroll-threshold.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
5 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html"> 5 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html">
6 <link rel="import" href="chrome://history/browser_service.html"> 6 <link rel="import" href="chrome://history/browser_service.html">
7 <link rel="import" href="chrome://history/constants.html"> 7 <link rel="import" href="chrome://history/constants.html">
8 <link rel="import" href="chrome://history/history_item.html"> 8 <link rel="import" href="chrome://history/history_item.html">
9 <link rel="import" href="chrome://history/shared_style.html"> 9 <link rel="import" href="chrome://history/shared_style.html">
10 10
(...skipping 15 matching lines...) Expand all
26 -webkit-user-select: none; 26 -webkit-user-select: none;
27 cursor: pointer; 27 cursor: pointer;
28 font: inherit; 28 font: inherit;
29 } 29 }
30 30
31 paper-item:hover { 31 paper-item:hover {
32 background: #eaeaea; 32 background: #eaeaea;
33 } 33 }
34 </style> 34 </style>
35 <div id="no-results" class="centered-message" 35 <div id="no-results" class="centered-message"
36 hidden$="{{hasResults(historyData.length)}}"> 36 hidden$="{{hasResults(historyData_.length)}}">
37 {{noResultsMessage_(searchedTerm, querying)}} 37 {{noResultsMessage_(searchedTerm, querying)}}
38 </div> 38 </div>
39 <iron-list items="{{historyData}}" as="item" id="infinite-list" 39 <iron-list items="{{historyData_}}" as="item" id="infinite-list"
40 hidden$="{{!hasResults(historyData.length)}}"> 40 hidden$="{{!hasResults(historyData_.length)}}">
41 <template> 41 <template>
42 <history-item item="[[item]]" 42 <history-item item="[[item]]"
43 starred="[[item.starred]]" 43 starred="[[item.starred]]"
44 selected="{{item.selected}}" 44 selected="{{item.selected}}"
45 is-card-start="[[isCardStart_(item, index, historyData.length)]]" 45 is-card-start="[[isCardStart_(item, index, historyData_.length)]]"
46 is-card-end="[[isCardEnd_(item, index, historyData.length)]]" 46 is-card-end="[[isCardEnd_(item, index, historyData_.length)]]"
47 has-time-gap="[[needsTimeGap_(item, index, historyData.length)]]" 47 has-time-gap="[[needsTimeGap_(item, index, historyData_.length)]]"
48 search-term="[[searchedTerm]]" 48 search-term="[[searchedTerm]]"
49 number-of-items="[[historyData.length]]"> 49 number-of-items="[[historyData_.length]]">
50 </history-item> 50 </history-item>
51 </template> 51 </template>
52 </iron-list> 52 </iron-list>
53 <iron-scroll-threshold id="scroll-threshold" scroll-target="infinite-list" 53 <iron-scroll-threshold id="scroll-threshold" scroll-target="infinite-list"
54 lower-threshold="500" on-lower-threshold="loadMoreData_"> 54 lower-threshold="500" on-lower-threshold="loadMoreData_">
55 </iron-scroll-threshold> 55 </iron-scroll-threshold>
56 <cr-shared-menu id="sharedMenu"> 56 <cr-shared-menu id="sharedMenu">
57 <paper-item id="menuMoreButton" on-tap="onMoreFromSiteTap_"> 57 <paper-item id="menuMoreButton" on-tap="onMoreFromSiteTap_">
58 $i18n{moreFromSite} 58 $i18n{moreFromSite}
59 </paper-item> 59 </paper-item>
60 <paper-item id="menuRemoveButton" on-tap="onRemoveFromHistoryTap_"> 60 <paper-item id="menuRemoveButton" on-tap="onRemoveFromHistoryTap_">
61 $i18n{removeFromHistory} 61 $i18n{removeFromHistory}
62 </paper-item> 62 </paper-item>
63 </cr-shared-menu> 63 </cr-shared-menu>
64 </template> 64 </template>
65 <script src="chrome://history/history_list.js"></script> 65 <script src="chrome://history/history_list.js"></script>
66 </dom-module> 66 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698