[MD History] Move Clear Browsing Data button to sidebar.

[MD History] Move Clear Browsing Data button to sidebar.

BUG=609536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/afde982b8e7f94e9e5e17c0865f305714c3d7120
Cr-Commit-Position: refs/heads/master@{#392559}

[calamity, 2016-05-05 19:26:45]

Patchset #1 (id:1) has been deleted

[calamity, 2016-05-05 19:26:57]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-05-05 19:27:05]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-05-05 21:29:31]

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:103: <div
id="centered-content">
I think you can simplify the structure of this toolbar a bit more now. Try
getting rid of #centered-content, and applying its layout properties to
#right-content instead?

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:10: --side-bar-width:
256px;
I'm not sure if this is meant to be the new width for us -- bettes@ said that it
was *not* the width in the settings spec. We should clarify.

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.html:55: <paper-item
on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
It's a little weird to use a paper-item here since it will end up selecting a
null page while it's navigating to clear browsing data. The history page goes
blank for a second before navigating to settings. Not a big deal, but it would
be nice to fix it.

[calamity, 2016-05-10 03:15:16]

Description was changed from

==========
[MD History] Move Clear Browsing Data button to sidebar.

BUG=609536
==========

to

==========
[MD History] Move Clear Browsing Data button to sidebar.

BUG=609536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-10 03:15:26]

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:103: <div
id="centered-content">
On 2016/05/05 21:29:30, tsergeant (MTV) wrote:
> I think you can simplify the structure of this toolbar a bit more now. Try
> getting rid of #centered-content, and applying its layout properties to
> #right-content instead?

This is getting superceded soon by the new toolbar anyway?

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:10: --side-bar-width:
256px;
On 2016/05/05 21:29:31, tsergeant (MTV) wrote:
> I'm not sure if this is meant to be the new width for us -- bettes@ said that
it
> was *not* the width in the settings spec. We should clarify.

Resolved.

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1952283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.html:55: <paper-item
on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
On 2016/05/05 21:29:31, tsergeant (MTV) wrote:
> It's a little weird to use a paper-item here since it will end up selecting a
> null page while it's navigating to clear browsing data. The history page goes
> blank for a second before navigating to settings. Not a big deal, but it would
> be nice to fix it.

Fixed that issue. I think paper-item is nice because it reflects the style of
the other items. I tried button. It looked very out of place and inconsistent.

[tsergeant, 2016-05-10 03:51:06]

lgtm

[calamity, 2016-05-10 06:34:26]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-05-10 06:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952283002/60001

[commit-bot: I haz the power, 2016-05-10 07:16:45]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-10 07:18:04]

Description was changed from

==========
[MD History] Move Clear Browsing Data button to sidebar.

BUG=609536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Move Clear Browsing Data button to sidebar.

BUG=609536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/afde982b8e7f94e9e5e17c0865f305714c3d7120
Cr-Commit-Position: refs/heads/master@{#392559}
==========

[commit-bot: I haz the power, 2016-05-10 07:18:05]

Patchset 2 (id:??) landed as
https://crrev.com/afde982b8e7f94e9e5e17c0865f305714c3d7120
Cr-Commit-Position: refs/heads/master@{#392559}