chrome/browser/android/shortcut_info.cc - Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_info.cc

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java ('K') | « chrome/browser/android/shortcut_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_info.cc

diff --git a/chrome/browser/android/shortcut_info.cc b/chrome/browser/android/shortcut_info.cc

index bb19d64d3a839288ad2efd05bd3ac07502b104cf..85a7e0037ae1597c300d7e8aedae65e7e4af468f 100644

--- a/chrome/browser/android/shortcut_info.cc

+++ b/chrome/browser/android/shortcut_info.cc

@@ -40,10 +40,7 @@ void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {

if (manifest.display != blink::WebDisplayModeUndefined)

display = manifest.display;

- // 'fullscreen' and 'minimal-ui' are not yet supported, fallback to the right

- // mode in those cases.

- if (manifest.display == blink::WebDisplayModeFullscreen)

- display = blink::WebDisplayModeStandalone;

+ // 'minimal-ui' is not yet supported, so fallback in this case.

mlamouri (slow - plz ping) 2016/05/11 10:18:57 Can you point to the minimal-ui BUG?

if (manifest.display == blink::WebDisplayModeMinimalUi)

display = blink::WebDisplayModeBrowser;

« chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java ('K') | « chrome/browser/android/shortcut_helper.cc ('k') | no next file » | no next file with comments »