Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.cc
diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc
index 13ae7b3dff65bc0ed30708acbd85871bd7affc59..0acad4c9ae003ff7f0814831c526bebf0da3750a 100644
--- a/chrome/browser/android/shortcut_helper.cc
+++ b/chrome/browser/android/shortcut_helper.cc
@@ -85,9 +85,8 @@ void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(
java_bitmap = gfx::ConvertToJavaBitmap(&icon_bitmap);
uintptr_t callback_pointer = 0;
- bool is_webapp_capable = info.display == blink::WebDisplayModeStandalone;
-
- if (is_webapp_capable) {
+ if (info.display == blink::WebDisplayModeStandalone ||
+ info.display == blink::WebDisplayModeFullscreen) {
// The callback will need to be run after shortcut creation completes in
// order to download the splash image and save it to the WebappDataStorage.
// Create a copy of the callback here and send the pointer to Java, which
@@ -106,7 +105,7 @@ void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(
java_name.obj(),
java_short_name.obj(),
java_bitmap.obj(),
- is_webapp_capable,
+ info.display,
info.orientation,
info.source,
info.theme_color,

Powered by Google App Engine
This is Rietveld 408576698