Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4415)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
index 92e6bf64422c4dd5d4f5eae29f6360bf84cea420..382e5c808c9bd099bc415698f3876c8f5307b563 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
@@ -245,13 +245,14 @@ public class WebappDataStorageTest {
final String name = "name";
final String shortName = "shortName";
final Bitmap icon = createBitmap();
+ final int displayMode = 3;
gone 2016/05/10 19:41:20 Shouldn't you be using a real displayMode here?
dominickn 2016/05/11 04:24:21 Yes, I should. However, the tests didn't compile w
mlamouri (slow - plz ping) 2016/05/11 10:18:57 I think you can add: "//third_party/WebKit/public:
final int orientation = 1;
final long themeColor = 2;
final long backgroundColor = 3;
final boolean isIconGenerated = false;
Intent shortcutIntent = ShortcutHelper.createWebappShortcutIntent(id, action, url, scope,
- name, shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, orientation,
- themeColor, backgroundColor, isIconGenerated);
+ name, shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, displayMode,
+ orientation, themeColor, backgroundColor, isIconGenerated);
WebappDataStorage storage = WebappDataStorage.open(Robolectric.application, "test");
storage.updateFromShortcutIntent(shortcutIntent);

Powered by Google App Engine
This is Rietveld 408576698