Remove ExtensionService::IsExternalExtensionUninstalled()

Remove ExtensionService::IsExternalExtensionUninstalled()
Replace with ExtensionPrefs::IsExternalExtensionUninstalled()

BUG=351891
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259081

[Devlin, 2014-03-14 15:38:36]

When time allows

[Yoyo Zhou, 2014-03-18 01:23:36]

LGTM

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
File extensions/browser/pending_extension_manager.cc (right):

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
extensions/browser/pending_extension_manager.cc:157: if
(ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id))
Could also use service->GetBrowserContext here.

[Devlin, 2014-03-18 17:24:12]

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
File extensions/browser/pending_extension_manager.cc (right):

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
extensions/browser/pending_extension_manager.cc:157: if
(ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id))
On 2014/03/18 01:23:37, Yoyo Zhou wrote:
> Could also use service->GetBrowserContext here.

Actually, can't... |service_| is an ExtensionServiceInterface, which doesn't
have the GetBrowserContext method. Options:
1. Add a GetBrowserContext() to ExtensionServiceInterface (which also means
adding it to TestExtensionService).
2. Now that PendingExtensionManager is back in chrome/, it could take a real
ExtensionService.
3. Leave it like this.

Preferences?

[Yoyo Zhou, 2014-03-22 00:34:37]

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
File extensions/browser/pending_extension_manager.cc (right):

https://chromiumcodereview.appspot.com/195813007/diff/20001/extensions/browse...
extensions/browser/pending_extension_manager.cc:157: if
(ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id))
On 2014/03/18 17:24:12, D Cronin wrote:
> On 2014/03/18 01:23:37, Yoyo Zhou wrote:
> > Could also use service->GetBrowserContext here.
> 
> Actually, can't... |service_| is an ExtensionServiceInterface, which doesn't
> have the GetBrowserContext method. Options:
> 1. Add a GetBrowserContext() to ExtensionServiceInterface (which also means
> adding it to TestExtensionService).
> 2. Now that PendingExtensionManager is back in chrome/, it could take a real
> ExtensionService.
> 3. Leave it like this.
> 
> Preferences?

May as well leave it as is for now then.

[Devlin, 2014-03-23 17:44:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-23 17:44:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/195813007/...

[commit-bot: I haz the power, 2014-03-23 17:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-23 17:45:58]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[Devlin, 2014-03-23 21:56:49]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-23 21:56:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/195813007/...

[commit-bot: I haz the power, 2014-03-23 22:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-23 22:25:12]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[Devlin, 2014-03-24 02:50:21]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-24 02:50:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/195813007/...

[commit-bot: I haz the power, 2014-03-24 02:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 02:53:03]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[Devlin, 2014-03-24 18:13:40]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/195813007/...

[commit-bot: I haz the power, 2014-03-24 18:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:14:29]

Failed to apply patch for
chrome/browser/extensions/pending_extension_manager.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/pending_extension_manager.cc
  Hunk #3 FAILED at 149.
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/pending_extension_manager.cc.rej

Patch:       chrome/browser/extensions/pending_extension_manager.cc
Index: chrome/browser/extensions/pending_extension_manager.cc
diff --git a/chrome/browser/extensions/pending_extension_manager.cc
b/chrome/browser/extensions/pending_extension_manager.cc
index
e2a636dbb9ff6432b04e867da126e917b7cc0f2c..a1172b7dbc3449e28c3879bf08f43b8feaf87e65
100644
--- a/chrome/browser/extensions/pending_extension_manager.cc
+++ b/chrome/browser/extensions/pending_extension_manager.cc
@@ -10,6 +10,7 @@
 #include "base/version.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "content/public/browser/browser_thread.h"
+#include "extensions/browser/extension_prefs.h"
 #include "extensions/common/extension.h"
 #include "url/gurl.h"
 
@@ -31,9 +32,9 @@ std::string GetVersionString(const Version& version) {
 namespace extensions {
 
 PendingExtensionManager::PendingExtensionManager(
-    const ExtensionServiceInterface& service)
-    : service_(service) {
-}
+    const ExtensionServiceInterface& service,
+    content::BrowserContext* context)
+    : service_(service), context_(context) {}
 
 PendingExtensionManager::~PendingExtensionManager() {}
 
@@ -148,13 +149,12 @@ bool PendingExtensionManager::AddFromExternalUpdateUrl(
   const bool kInstallSilently = true;
 
   const Extension* extension = service_.GetInstalledExtension(id);
-  if (extension &&
-      location == Manifest::GetHigherPriorityLocation(location,
-                                                       extension->location()))
{
+  if (extension && location == Manifest::GetHigherPriorityLocation(
+                                   location, extension->location())) {
     // If the new location has higher priority than the location of an existing
     // extension, let the update process overwrite the existing extension.
   } else {
-    if (service_.IsExternalExtensionUninstalled(id))
+    if (ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id))
       return false;
 
     if (extension) {

[Devlin, 2014-03-24 21:37:51]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-24 21:38:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/195813007/...

[commit-bot: I haz the power, 2014-03-25 01:22:51]

Change committed as 259081