chrome/browser/extensions/extension_sync_service.cc - Issue 195813007: Remove ExtensionService::IsExternalExtensionUninstalled()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 195813007: Remove ExtensionService::IsExternalExtensionUninstalled() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/pending_extension_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_service.cc

diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc

index ee1a12218fb21a5bf3ba534b759b2de842b70c25..472c5d5e751b8683a43fd91ddeffc78ae8a47e07 100644

--- a/chrome/browser/extensions/extension_sync_service.cc

+++ b/chrome/browser/extensions/extension_sync_service.cc

@@ -385,7 +385,8 @@ bool ExtensionSyncService::ProcessExtensionSyncDataHelper(

// Extension from sync was uninstalled by the user as external extensions.

// Honor user choice and skip installation/enabling.

- if (extension_service_->IsExternalExtensionUninstalled(id)) {

+ if (extensions::ExtensionPrefs::Get(profile_)

+ ->IsExternalExtensionUninstalled(id)) {

LOG(WARNING) << "Extension with id " << id

<< " from sync was uninstalled as external extension";

return true;

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/pending_extension_manager.h » ('j') | no next file with comments »