Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 195813007: Remove ExtensionService::IsExternalExtensionUninstalled() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 const std::string& id, 91 const std::string& id,
92 bool include_disabled) const = 0; 92 bool include_disabled) const = 0;
93 virtual const extensions::Extension* GetInstalledExtension( 93 virtual const extensions::Extension* GetInstalledExtension(
94 const std::string& id) const = 0; 94 const std::string& id) const = 0;
95 95
96 virtual const extensions::Extension* GetPendingExtensionUpdate( 96 virtual const extensions::Extension* GetPendingExtensionUpdate(
97 const std::string& extension_id) const = 0; 97 const std::string& extension_id) const = 0;
98 virtual void FinishDelayedInstallation(const std::string& extension_id) = 0; 98 virtual void FinishDelayedInstallation(const std::string& extension_id) = 0;
99 99
100 virtual bool IsExtensionEnabled(const std::string& extension_id) const = 0; 100 virtual bool IsExtensionEnabled(const std::string& extension_id) const = 0;
101 virtual bool IsExternalExtensionUninstalled(
102 const std::string& extension_id) const = 0;
103 101
104 virtual void CheckManagementPolicy() = 0; 102 virtual void CheckManagementPolicy() = 0;
105 103
106 // Safe to call multiple times in a row. 104 // Safe to call multiple times in a row.
107 // 105 //
108 // TODO(akalin): Remove this method (and others) once we refactor 106 // TODO(akalin): Remove this method (and others) once we refactor
109 // themes sync to not use it directly. 107 // themes sync to not use it directly.
110 virtual void CheckForUpdatesSoon() = 0; 108 virtual void CheckForUpdatesSoon() = 0;
111 109
112 virtual void AddExtension(const extensions::Extension* extension) = 0; 110 virtual void AddExtension(const extensions::Extension* extension) = 0;
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 // are going to delete in this function. 239 // are going to delete in this function.
242 // 240 //
243 // TODO(aa): Remove |external_uninstall| -- this information should be passed 241 // TODO(aa): Remove |external_uninstall| -- this information should be passed
244 // to ExtensionPrefs some other way. 242 // to ExtensionPrefs some other way.
245 virtual bool UninstallExtension(std::string extension_id, 243 virtual bool UninstallExtension(std::string extension_id,
246 bool external_uninstall, 244 bool external_uninstall,
247 base::string16* error); 245 base::string16* error);
248 246
249 virtual bool IsExtensionEnabled( 247 virtual bool IsExtensionEnabled(
250 const std::string& extension_id) const OVERRIDE; 248 const std::string& extension_id) const OVERRIDE;
251 virtual bool IsExternalExtensionUninstalled(
252 const std::string& extension_id) const OVERRIDE;
253 249
254 // Enables the extension. If the extension is already enabled, does 250 // Enables the extension. If the extension is already enabled, does
255 // nothing. 251 // nothing.
256 virtual void EnableExtension(const std::string& extension_id); 252 virtual void EnableExtension(const std::string& extension_id);
257 253
258 // Disables the extension. If the extension is already disabled, or 254 // Disables the extension. If the extension is already disabled, or
259 // cannot be disabled, does nothing. 255 // cannot be disabled, does nothing.
260 virtual void DisableExtension(const std::string& extension_id, 256 virtual void DisableExtension(const std::string& extension_id,
261 extensions::Extension::DisableReason disable_reason); 257 extensions::Extension::DisableReason disable_reason);
262 258
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 804 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
809 GreylistedExtensionDisabled); 805 GreylistedExtensionDisabled);
810 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 806 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
811 GreylistDontEnableManuallyDisabled); 807 GreylistDontEnableManuallyDisabled);
812 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 808 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
813 GreylistUnknownDontChange); 809 GreylistUnknownDontChange);
814 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 810 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
815 }; 811 };
816 812
817 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 813 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698