[MD History] Make side bar always visible.

[MD History] Make side bar always visible.

BUG=609536
Committed: https://crrev.com/7bfd722eee4353e00bd8dd672c8ee07d56c2b1e4
Cr-Commit-Position: refs/heads/master@{#391900}

[calamity, 2016-05-05 17:46:55]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-05-05 17:59:10]

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/app.js (left):

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/app.js:95: // TODO(calamity): Add a 'no
synced devices' message when sessions are
This TODO is still relevant.

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/app.js:102: /** @type
{HistoryToolbarElement} */(this.$.toolbar).hasSidebar = true;
Can you please change the implementation of history-toolbar to get rid of
hasSidebar, since it will always be true?

[calamity, 2016-05-05 18:47:34]

Patchset #2 (id:20001) has been deleted

[calamity, 2016-05-05 18:49:06]

Patchset #2 (id:40001) has been deleted

[calamity, 2016-05-05 18:49:33]

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/app.js (left):

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/app.js:95: // TODO(calamity): Add a 'no
synced devices' message when sessions are
On 2016/05/05 17:59:09, tsergeant (MTV) wrote:
> This TODO is still relevant.

Reinstated.

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/1955613002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/app.js:102: /** @type
{HistoryToolbarElement} */(this.$.toolbar).hasSidebar = true;
On 2016/05/05 17:59:09, tsergeant (MTV) wrote:
> Can you please change the implementation of history-toolbar to get rid of
> hasSidebar, since it will always be true?

Good point. Done. I'll remove more of the extraneous stuff next patch when I
move the CBD button.

[tsergeant, 2016-05-05 18:55:50]

lgtm

[calamity, 2016-05-05 19:27:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:27:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955613002/60001

[commit-bot: I haz the power, 2016-05-05 21:30:28]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-05 21:31:32]

Description was changed from

==========
[MD History] Make side bar always visible.

BUG=609536
==========

to

==========
[MD History] Make side bar always visible.

BUG=609536

Committed: https://crrev.com/7bfd722eee4353e00bd8dd672c8ee07d56c2b1e4
Cr-Commit-Position: refs/heads/master@{#391900}
==========

[commit-bot: I haz the power, 2016-05-05 21:31:32]

Patchset 2 (id:??) landed as
https://crrev.com/7bfd722eee4353e00bd8dd672c8ee07d56c2b1e4
Cr-Commit-Position: refs/heads/master@{#391900}