Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5958)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 1955613002: [MD History] Make side bar always visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mdh_fuckit_refactor_it_all
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_toolbar.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index 0d68ff73cf2a85e2e6e4b62ed74c743d8a9261c9..29ebdf37bc8108548308fcd88bf17ec144f0f146 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -92,16 +92,15 @@ Polymer({
* @param {boolean} isTabSyncEnabled Is tab sync enabled for this profile?
*/
setForeignSessions: function(sessionList, isTabSyncEnabled) {
+ if (!isTabSyncEnabled)
+ return;
+
// TODO(calamity): Add a 'no synced devices' message when sessions are
// empty.
- this.$['history-side-bar'].hidden = !isTabSyncEnabled;
var syncedDeviceElem = this.$['history-synced-device-manager'];
var syncedDeviceManager =
/** @type {HistorySyncedDeviceManagerElement} */(syncedDeviceElem);
- if (isTabSyncEnabled) {
- syncedDeviceManager.setSyncedHistory(sessionList);
- /** @type {HistoryToolbarElement} */(this.$.toolbar).hasSidebar = true;
- }
+ syncedDeviceManager.setSyncedHistory(sessionList);
},
deleteComplete: function() {
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_toolbar.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698