Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: chrome/browser/extensions/convert_web_app.cc

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/convert_web_app.cc
diff --git a/chrome/browser/extensions/convert_web_app.cc b/chrome/browser/extensions/convert_web_app.cc
index 5f844aba93fe6c56cdd8cd5d67cb59b7d42a5836..2ed22f32cda97e3e6a0e34278ac15a686c993785 100644
--- a/chrome/browser/extensions/convert_web_app.cc
+++ b/chrome/browser/extensions/convert_web_app.cc
@@ -57,8 +57,7 @@ std::string GenerateKey(const GURL& manifest_url) {
return key;
}
-}
-
+} // namespace
// Generates a version for the converted app using the current date. This isn't
// really needed, but it seems like useful information.
@@ -144,7 +143,8 @@ scoped_refptr<Extension> ConvertWebAppToExtension(
}
// Write the manifest.
- base::FilePath manifest_path = temp_dir.path().Append(kManifestFilename);
+ base::FilePath manifest_path = temp_dir.path().Append(
+ filenames::kManifestFilename);
JSONFileValueSerializer serializer(manifest_path);
if (!serializer.Serialize(*root)) {
LOG(ERROR) << "Could not serialize manifest.";

Powered by Google App Engine
This is Rietveld 408576698