Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

extensions/common/constants.h

Index: extensions/common/constants.h
diff --git a/extensions/common/constants.h b/extensions/common/constants.h
index aeb9e674acbd69840180aaaad1562e8ba7bb9dc3..bf4b9d4435cedd31d860bbeb26b26b73c0d66cae 100644
--- a/extensions/common/constants.h
+++ b/extensions/common/constants.h
@@ -12,6 +12,8 @@ namespace extensions {
 // Scheme we serve extension content from.
 extern const char kExtensionScheme[];
 
+namespace filenames {
+
   // The name of the manifest inside an extension.
 extern const base::FilePath::CharType kManifestFilename[];
 
@@ -28,6 +30,35 @@ extern const base::FilePath::CharType kPlatformSpecificFolder[];
 // installed to.
 extern const char kInstallDirectoryName[];
 
+// The name of a temporary directory to install an extension into for
+// validation before finalizing install.
+extern const char kTempExtensionName[];
+
+// The file to write our decoded images to, relative to the extension_path.
+extern const char kDecodedImagesFilename[];
+
+// The file to write our decoded message catalogs to, relative to the
+// extension_path.
+extern const char kDecodedMessageCatalogsFilename[];
+
+// The filename to use for a background page generated from
+// background.scripts.
+extern const char kGeneratedBackgroundPageFilename[];
+
+// Path to imported modules.
+extern const char kModulesDir[];
+
+// The file extension (.crx) for extensions.
+extern const base::FilePath::CharType kExtensionFileExtension[];
+
+// The file extension (.pem) for private key files.
+extern const base::FilePath::CharType kExtensionKeyFileExtension[];
+
+// Returns true if the specified file is an extension.
+bool IsExtension(const base::FilePath& file_name);

[Matt Perry, 2013/07/18 23:01:52]

This is not a constant. It doesn't feel like it belongs here.

Also, as long as you're touching this code, it could use a more descriptive
name, like HasExtensionFilename.

[Yoyo Zhou, 2013/07/19 22:07:45]

extension_constants.cc has a bunch of helper functions like this, which is why I
thought it was okay. Anyway, this was only used in 2 places, and we don't have
one for .pem files, so I just removed it.

+
+}  // namespace filenames
+
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_CONSTANTS_H_