Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

chrome/browser/extensions/convert_web_app.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/convert_web_app.h"
 
 #include <cmath>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 39 matching lines @@
 // manifest and regenerates these extensions.
 std::string GenerateKey(const GURL& manifest_url) {
   char raw[crypto::kSHA256Length] = {0};
   std::string key;
   crypto::SHA256HashString(manifest_url.spec().c_str(), raw,
                            crypto::kSHA256Length);
   base::Base64Encode(std::string(raw, crypto::kSHA256Length), &key);
   return key;
 }
 
-}
-
+}  // namespace
 
 // Generates a version for the converted app using the current date. This isn't
 // really needed, but it seems like useful information.
 std::string ConvertTimeToExtensionVersion(const Time& create_time) {
   Time::Exploded create_time_exploded;
   create_time.UTCExplode(&create_time_exploded);
 
   double micros = static_cast<double>(
       (create_time_exploded.millisecond * Time::kMicrosecondsPerMillisecond) +
       (create_time_exploded.second * Time::kMicrosecondsPerSecond) +
@@ skipping 65 matching lines @@
   }
 
   // Add the URLs.
   base::ListValue* urls = new base::ListValue();
   root->Set(keys::kWebURLs, urls);
   for (size_t i = 0; i < web_app.urls.size(); ++i) {
     urls->Append(Value::CreateStringValue(web_app.urls[i].spec()));
   }
 
   // Write the manifest.
-  base::FilePath manifest_path = temp_dir.path().Append(kManifestFilename);
+  base::FilePath manifest_path = temp_dir.path().Append(
+      filenames::kManifestFilename);
   JSONFileValueSerializer serializer(manifest_path);
   if (!serializer.Serialize(*root)) {
     LOG(ERROR) << "Could not serialize manifest.";
     return NULL;
   }
 
   // Write the icon files.
   base::FilePath icons_dir = temp_dir.path().AppendASCII(kIconsDirName);
   if (!file_util::CreateDirectory(icons_dir)) {
     LOG(ERROR) << "Could not create icons directory.";
@@ skipping 35 matching lines @@
   if (!extension.get()) {
     LOG(ERROR) << error;
     return NULL;
   }
 
   temp_dir.Take();  // The caller takes ownership of the directory.
   return extension;
 }
 
 }  // namespace extensions