Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 19492009: Revert 212538 "[SystemInfo API] Rename systemInfo Memory API." (Closed)

Created:
7 years, 5 months ago by Vladislav Kaznacheev
Modified:
7 years, 5 months ago
Reviewers:
hokein.wu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 212538 "[SystemInfo API] Rename systemInfo Memory API." > [SystemInfo API] Rename systemInfo Memory API. > > Rename from "systemInfo.memory.get" to "system.memory.getInfo". > > BUG=252994 > TEST=browser_tests --gtest_filter=SystemMemoryApiTest.* > > Review URL: https://chromiumcodereview.appspot.com/18863014 TBR=Hokein.Wu@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -257 lines) Patch
M trunk/src/chrome/browser/extensions/activity_log/api_name_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_info_memory/memory_info_provider.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_info_memory/memory_info_provider.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_info_memory/system_info_memory_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_info_memory/system_info_memory_api.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_memory/memory_info_provider.h View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_memory/memory_info_provider.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_memory/system_memory_api.h View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_memory/system_memory_api.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_memory/system_memory_apitest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_function_histogram_value.h View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/api/_api_features.json View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/chrome/common/extensions/api/system_info_memory.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/common/extensions/api/system_memory.idl View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/public/apps/redirects.json View 1 chunk +1 line, -2 lines 0 comments Download
A + trunk/src/chrome/common/extensions/docs/templates/public/apps/systemInfo_memory.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/system_memory.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/public/extensions/redirects.json View 1 chunk +1 line, -2 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/system_memory.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/system/memory/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/system/memory/test_memory_api.js View 1 chunk +0 lines, -18 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/api_test/systeminfo/memory/test_memory_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
7 years, 5 months ago (2013-07-19 13:47:54 UTC) #1
Vladislav Kaznacheev
Committed patchset #1 manually as r212583.
7 years, 5 months ago (2013-07-19 13:48:49 UTC) #2
Vladislav Kaznacheev
On 2013/07/19 13:48:49, Vladislav Kaznacheev wrote: > Committed patchset #1 manually as r212583. Sorry, I ...
7 years, 5 months ago (2013-07-19 13:51:58 UTC) #3
Hongbo Min
7 years, 5 months ago (2013-07-22 01:46:54 UTC) #4
Message was sent while issue was closed.
On 2013/07/19 13:51:58, Vladislav Kaznacheev wrote:
> On 2013/07/19 13:48:49, Vladislav Kaznacheev wrote:
> > Committed patchset #1 manually as r212583.
> 
> Sorry, I forgot to add this to the commit message:
> The reason for this revert is that r212538 consistently broke browser_tests on
> Mac bots (starting with
>
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%2520Tests%2520%2528...).
> Reverting to see if this helps.

After discussing with Haojian, there might be some exception happened on
buildbot.

According to the error message in Mac buildbot you give, it indicated that
SystemInfoMemoryApiTest.Memory failed, however, the CL
https://chromiumcodereview.appspot.com/18863014 already renamed
'SystemInfoMemoryApiTest' to 'SystemMemoryApiTest', see
https://codereview.chromium.org/18863014/diff/59033/chrome/browser/extensions...,
so it is expected that there is no SystemInfoMemoryApiTest any more.

Haojian is working on this issue and submitted the reverted CL again at
https://codereview.chromium.org/19912002/, and try to figure out what is
happened on Mac buildbot.

Powered by Google App Engine
This is Rietveld 408576698