Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18863014: [SystemInfo API] Rename systemInfo Memory API. (Closed)

Created:
7 years, 5 months ago by Haojian Wu
Modified:
7 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[SystemInfo API] Rename systemInfo Memory API. Rename from "systemInfo.memory.get" to "system.memory.getInfo". BUG=252994 TEST=browser_tests --gtest_filter=SystemMemoryApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212538

Patch Set 1 #

Patch Set 2 : No need to redirect docs. #

Patch Set 3 : Correct the permission keyname in permission_set_unittest. #

Patch Set 4 : Add new API name in activity log. #

Patch Set 5 : Add docs redirect. #

Total comments: 1

Patch Set 6 : Change test code file path and upate commit message. #

Patch Set 7 : Rebase to trunk. #

Patch Set 8 : Rebase to trunk #

Patch Set 9 : #

Patch Set 10 : Rebase #

Patch Set 11 : Update commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -298 lines) Patch
M chrome/browser/extensions/activity_log/api_name_constants.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/system_info_memory/memory_info_provider.h View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/memory_info_provider.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_api.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_api.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -59 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/memory_info_provider.h View 1 2 3 4 5 6 2 chunks +7 lines, -9 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/memory_info_provider.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/extensions/api/system_memory/system_memory_api.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/system_memory_api.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/system_memory_apitest.cc View 1 2 3 4 5 6 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/system_info_memory.idl View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/common/extensions/api/system_memory.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/redirects.json View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/systemInfo_memory.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/system_memory.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/redirects.json View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/system_memory.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/system/memory/manifest.json View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/api_test/system/memory/test_memory_api.js View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json View 1 2 3 4 5 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/memory/test_memory_api.js View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Haojian Wu
hongbo@ for initial review. Greg@ for new cpu api name. kalman@ for cpu api docs ...
7 years, 5 months ago (2013-07-14 01:43:48 UTC) #1
not at google - send to devlin
Is there really no BUG on this? There should be. TEST lines are for verification, ...
7 years, 5 months ago (2013-07-15 19:23:48 UTC) #2
not at google - send to devlin
I mean to say lgtm after the commit message is fixed. It looks like it ...
7 years, 5 months ago (2013-07-15 19:24:09 UTC) #3
not at google - send to devlin
please also add entry in redirects.json
7 years, 5 months ago (2013-07-15 19:32:19 UTC) #4
Ilya Sherman
histograms.xml LGTM, though please double-check when fixing up any merge conflicts with your other CLs ...
7 years, 5 months ago (2013-07-16 00:29:15 UTC) #5
Haojian Wu
On 2013/07/15 19:32:19, kalman wrote: > please also add entry in redirects.json Done.
7 years, 5 months ago (2013-07-16 03:10:39 UTC) #6
Greg Billock
lgtm https://codereview.chromium.org/18863014/diff/18001/chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json File chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json (right): https://codereview.chromium.org/18863014/diff/18001/chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json#newcode1 chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json:1: { Not urgent, but we should move these ...
7 years, 5 months ago (2013-07-16 17:43:22 UTC) #7
Haojian Wu
On 2013/07/16 17:43:22, Greg Billock wrote: > lgtm > > https://codereview.chromium.org/18863014/diff/18001/chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json > File chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json > ...
7 years, 5 months ago (2013-07-18 10:50:02 UTC) #8
Hongbo Min
On 2013/07/18 10:50:02, Haojian Wu wrote: > On 2013/07/16 17:43:22, Greg Billock wrote: > > ...
7 years, 5 months ago (2013-07-19 01:21:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/18863014/27001
7 years, 5 months ago (2013-07-19 01:26:17 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-19 01:26:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/18863014/34001
7 years, 5 months ago (2013-07-19 02:01:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/18863014/34001
7 years, 5 months ago (2013-07-19 04:57:31 UTC) #13
commit-bot: I haz the power
Change committed as 212538
7 years, 5 months ago (2013-07-19 08:27:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/18863014/59033
7 years, 5 months ago (2013-07-21 02:44:44 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=16313
7 years, 5 months ago (2013-07-21 03:08:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/18863014/59033
7 years, 5 months ago (2013-07-21 03:42:27 UTC) #17
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 04:22:54 UTC) #18 
Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Powered by Google App Engine
This is Rietveld 408576698