Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935923002: client/flagpb: fix repeated bool without value (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 7 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

client/flagpb: fix repeated bool unmarshsling Fix by reducing the number of code paths R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/7e4ea4bbc8aa3614e53ab6ae181d16d66057e6bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M client/flagpb/unmarshal.go View 4 chunks +20 lines, -15 lines 0 comments Download
M client/flagpb/unmarshal_test.desc View Binary file 0 comments Download
M client/flagpb/unmarshal_test.go View 1 chunk +3 lines, -0 lines 0 comments Download
M client/flagpb/unmarshal_test.proto View 1 chunk +1 line, -0 lines 0 comments Download
M client/flagpb/unmarshal_test.pb_test.go View 2 chunks +17 lines, -15 lines 0 comments Download

Dependent Patchsets:

Issue 1940683002 Patch 1
Issue 1940683002 Patch 40001

Messages

Total messages: 10 (6 generated)
nodir
PTAL
4 years, 7 months ago (2016-04-30 03:58:03 UTC) #1
Vadim Sh.
lgtm
4 years, 7 months ago (2016-05-01 18:18:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935923002/1
4 years, 7 months ago (2016-05-01 21:49:17 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 21:52:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/7e4ea4bbc8aa3614e53ab6ae181d16d66057e6bd

Powered by Google App Engine
This is Rietveld 408576698