client/flagpb/unmarshal_test.go - Issue 1935923002: client/flagpb: fix repeated bool without value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/flagpb/unmarshal_test.go

Issue 1935923002: client/flagpb: fix repeated bool without value (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/flagpb/unmarshal_test.go

diff --git a/client/flagpb/unmarshal_test.go b/client/flagpb/unmarshal_test.go

index d441d069d2b55afab88e16b8ba43946e2280e056..790290303c38cb16dd9d1557164147c87008fb3f 100644

--- a/client/flagpb/unmarshal_test.go

+++ b/client/flagpb/unmarshal_test.go

@@ -94,6 +94,9 @@ func TestUnmarshal(t *testing.T) {

"s", "x",

))

})

+ Convey("without value, repeated", func() {

+ So(unmarshalOK("M1", "-rb=false", "-rb"), ShouldResemble, msg("rb", repeated(false, true)))

+ })

Convey("with value", func() {

So(unmarshalOK("M1", "-b=true"), ShouldResemble, msg("b", true))

So(unmarshalOK("M1", "-b=false"), ShouldResemble, msg("b", false))

« no previous file with comments | « client/flagpb/unmarshal_test.desc ('k') | client/flagpb/unmarshal_test.proto » ('j') | no next file with comments »