chrome/browser/plugins/plugin_observer.cc - Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/plugins/plugin_observer.cc

diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc

index a6a64a2e1ad9e5bb6be5b222c73ce740dd5288b8..ca638f8186e06bc8a116c6efc20085388a2171ef 100644

--- a/chrome/browser/plugins/plugin_observer.cc

+++ b/chrome/browser/plugins/plugin_observer.cc

@@ -83,8 +83,7 @@ ConfirmInstallDialogDelegate::ConfirmInstallDialogDelegate(

content::WebContents* web_contents,

PluginInstaller* installer,

scoped_ptr<PluginMetadata> plugin_metadata)

- : TabModalConfirmDialogDelegate(web_contents),

- WeakPluginInstallerObserver(installer),

+ : WeakPluginInstallerObserver(installer),

web_contents_(web_contents),

plugin_metadata_(plugin_metadata.Pass()) {

}

« no previous file with comments | « chrome/browser/download/download_danger_prompt.cc ('k') | chrome/browser/repost_form_warning_controller.cc » ('j') | no next file with comments »