Remove direct reference to GetBlockingPool() in c/b/google_apis.

Remove direct reference to GetBlockingPool() in c/b/google_apis.

Instead, a task runner is injected from the upper layer.
This is for removing the dependency to content/ from c/b/google_apis/ and
moving the directory content to the top level google_apis/.

BUG=256112
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210352

[kinaba, 2013-07-05 04:22:22]

Please take a look.

[satorux1, 2013-07-08 01:30:07]

LGTM with nits. sorry for the belated response.

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/ba...
File chrome/browser/google_apis/base_requests.h (right):

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/ba...
chrome/browser/google_apis/base_requests.h:213: // |callback| must not be null.
While you are at it, could you document what |callback| is for?

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/re...
File chrome/browser/google_apis/request_sender.h (right):

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/re...
chrome/browser/google_apis/request_sender.h:45: // requests issued through the
request sender if the value is not empty.
Please document |blocking_task_runner|

[kinaba, 2013-07-08 03:12:02]

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/ba...
File chrome/browser/google_apis/base_requests.h (right):

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/ba...
chrome/browser/google_apis/base_requests.h:213: // |callback| must not be null.
On 2013/07/08 01:30:07, satorux1 wrote:
> While you are at it, could you document what |callback| is for?

Done.

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/re...
File chrome/browser/google_apis/request_sender.h (right):

https://codereview.chromium.org/18742002/diff/1/chrome/browser/google_apis/re...
chrome/browser/google_apis/request_sender.h:45: // requests issued through the
request sender if the value is not empty.
On 2013/07/08 01:30:07, satorux1 wrote:
> Please document |blocking_task_runner|

Done.

[commit-bot: I haz the power, 2013-07-08 03:19:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/18742002/10001

[satorux1, 2013-07-08 03:52:04]

BTW, can you remove the following from DEPS?

  # BrowserThread should be gone: crbug.com/256112
  "!content/public/browser/browser_thread.h",

[satorux1, 2013-07-08 03:53:29]

hmm, maybe not bacause of google_apis::test_util::RunBlockingPoolTask(). we
should probably move this to c/b/chromeos/drive.

[satorux1, 2013-07-08 03:54:22]

https://codereview.chromium.org/18742002/diff/10001/chrome/browser/google_api...
File chrome/browser/google_apis/base_requests_unittest.cc (right):

https://codereview.chromium.org/18742002/diff/10001/chrome/browser/google_api...
chrome/browser/google_apis/base_requests_unittest.cc:66:
test_util::RunBlockingPoolTask();
this looks unnecessary?

[kinaba, 2013-07-08 03:57:06]

On 2013/07/08 03:53:29, satorux1 wrote:
> hmm, maybe not bacause of google_apis::test_util::RunBlockingPoolTask(). we
> should probably move this to c/b/chromeos/drive.

The patch for the task is already there in my local branch :)
Just a moment...

[commit-bot: I haz the power, 2013-07-08 06:58:54]

Change committed as 210352