Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: chrome/browser/google_apis/request_sender.h

Issue 18742002: Remove direct reference to GetBlockingPool() in c/b/google_apis. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix + rebase. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/request_sender.h
diff --git a/chrome/browser/google_apis/request_sender.h b/chrome/browser/google_apis/request_sender.h
index f20c394a4df582f55f3a208aba10e87053fe6db9..96b3fd10208468309469d4147575e2b4650f27d6 100644
--- a/chrome/browser/google_apis/request_sender.h
+++ b/chrome/browser/google_apis/request_sender.h
@@ -11,6 +11,7 @@
#include "base/basictypes.h"
#include "base/callback_forward.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/threading/thread_checker.h"
@@ -18,6 +19,10 @@
class Profile;
+namespace base {
+class TaskRunner;
+}
+
namespace net {
class URLRequestContextGetter;
}
@@ -31,8 +36,11 @@ class AuthService;
// AuthenticatedRequestInterface and handles retries and authentication.
class RequestSender {
public:
- // |url_request_context_getter| is used to perform authentication with
- // AuthService.
+ // |url_request_context_getter| is the context used to perform network
+ // requests from this RequestSender.
+ //
+ // |blocking_task_runner| is used for running blocking operation, e.g.,
+ // parsing JSON response from the server.
//
// |scopes| specifies OAuth2 scopes.
//
@@ -40,6 +48,7 @@ class RequestSender {
// requests issued through the request sender if the value is not empty.
RequestSender(Profile* profile,
net::URLRequestContextGetter* url_request_context_getter,
+ base::TaskRunner* blocking_task_runner,
const std::vector<std::string>& scopes,
const std::string& custom_user_agent);
virtual ~RequestSender();
@@ -50,6 +59,10 @@ class RequestSender {
return url_request_context_getter_;
}
+ base::TaskRunner* blocking_task_runner() const {
+ return blocking_task_runner_.get();
+ }
+
// Prepares the object for use.
virtual void Initialize();
@@ -85,6 +98,7 @@ class RequestSender {
Profile* profile_; // Not owned.
net::URLRequestContextGetter* url_request_context_getter_; // Not owned.
+ scoped_refptr<base::TaskRunner> blocking_task_runner_;
scoped_ptr<AuthService> auth_service_;
std::set<AuthenticatedRequestInterface*> in_flight_requests_;

Powered by Google App Engine
This is Rietveld 408576698