Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: chrome/browser/google_apis/base_requests_unittest.cc

Issue 18742002: Remove direct reference to GetBlockingPool() in c/b/google_apis. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix + rebase. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/base_requests_unittest.cc
diff --git a/chrome/browser/google_apis/base_requests_unittest.cc b/chrome/browser/google_apis/base_requests_unittest.cc
index 8e73ab371514acbc035320c964984a0c837d600d..306ec46a15219a23556ff07a8d93cb348dd8a76f 100644
--- a/chrome/browser/google_apis/base_requests_unittest.cc
+++ b/chrome/browser/google_apis/base_requests_unittest.cc
@@ -45,6 +45,7 @@ class BaseRequestsTest : public testing::Test {
profile_.reset(new TestingProfile);
sender_.reset(new RequestSender(profile_.get(),
NULL /* url_request_context_getter */,
+ message_loop_.message_loop_proxy(),
std::vector<std::string>() /* scopes */,
std::string() /* custom user agent */));
sender_->Initialize();
@@ -57,7 +58,8 @@ class BaseRequestsTest : public testing::Test {
TEST_F(BaseRequestsTest, ParseValidJson) {
scoped_ptr<base::Value> json;
- ParseJson(kValidJsonString,
+ ParseJson(message_loop_.message_loop_proxy(),
+ kValidJsonString,
base::Bind(test_util::CreateCopyResultCallback(&json)));
// Should wait for a blocking pool task, as the JSON parsing is done in the
// blocking pool.
@@ -75,7 +77,8 @@ TEST_F(BaseRequestsTest, ParseValidJson) {
TEST_F(BaseRequestsTest, ParseInvalidJson) {
// Initialize with a valid pointer to verify that null is indeed assigned.
scoped_ptr<base::Value> json(base::Value::CreateNullValue());
- ParseJson(kInvalidJsonString,
+ ParseJson(message_loop_.message_loop_proxy(),
+ kInvalidJsonString,
base::Bind(test_util::CreateCopyResultCallback(&json)));
// Should wait for a blocking pool task, as the JSON parsing is done in the
// blocking pool.
« no previous file with comments | « chrome/browser/google_apis/base_requests_server_unittest.cc ('k') | chrome/browser/google_apis/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698