Issue 18581007: Address comments directly in master, adjust for new sdk html fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18581007: Address comments directly in master, adjust for new sdk html fields. (Closed)

Created:
7 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

Address comments directly in master, adjust for new sdk html fields. R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/d60b5b5

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -19 lines)			Patch
M	lib/testing/render_test.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/web_ui.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/data/input/css_compile/index_apply_shadow_dom_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/input/css_compile/index_apply_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/input/css_compile/index_mangle_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/input/css_compile/index_reset_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/input/css_compile/index_shadow_dom_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/input/css_compile/index_test.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/run_all.dart	View	2 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Siggi Cherem (dart-lang)

7 years, 5 months ago (2013-07-02 23:37:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rd60b5b5 (presubmit successful).