Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: lib/testing/render_test.dart

Issue 18581007: Address comments directly in master, adjust for new sdk html fields. (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/web_ui.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/testing/render_test.dart
diff --git a/lib/testing/render_test.dart b/lib/testing/render_test.dart
index 3d3b52c047f9e51372db4be6da4a56d7de2c44ed..0c03abdb5e4bca7760fbf4de9f2f04bf35d5c0c4 100644
--- a/lib/testing/render_test.dart
+++ b/lib/testing/render_test.dart
@@ -15,9 +15,9 @@ import 'package:unittest/unittest.dart';
import 'package:web_ui/dwc.dart' as dwc;
void renderTests(String baseDir, String inputDir, String expectedDir,
- String outDir, [List<String> args, String script, String pattern,
- bool deleteDir = true]) {
- if (args == null) args = new Options().arguments;
+ String outDir, {List<String> arguments, String script, String pattern,
+ bool deleteDir: true}) {
+ if (arguments == null) arguments = new Options().arguments;
if (script == null) script = new Options().script;
var filePattern = new RegExp(pattern != null ? pattern : '.');
@@ -41,11 +41,11 @@ void renderTests(String baseDir, String inputDir, String expectedDir,
}
dir.createSync();
- args.addAll(['-o', outDir, '--basedir', baseDir]);
+ arguments.addAll(['-o', outDir, '--basedir', baseDir]);
for (var filePath in paths) {
var filename = path.basename(filePath);
test('compile $filename', () {
- var testArgs = args.toList();
+ var testArgs = arguments.toList();
testArgs.add(filePath);
expect(dwc.run(testArgs, printTime: false).then((res) {
expect(res.messages.length, 0, reason: res.messages.join('\n'));
« no previous file with comments | « no previous file | lib/web_ui.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698