Add fallback for DocumentModeAssassin

Add fallback for DocumentModeAssassin

* Adds a fallback to the DocumentModeAssassin so that it forces the
  user into tabbed mode without their data if migration keeps
  crashing.

* Refactors how the DocumentModeAssassin makes calls to get TabModels
  and Files in order to make more of it testable.

* Adds more tests for the DocumentModeAssassin for testing the full
  pipeline and various ways it can be skipped.

* Length of time to show the UpgradeActivity is upped to 1 second
  to avoid animation jank.

BUG=582539
Committed: https://crrev.com/1d1b05264afca07e10687e9c79f91df0ff1f2a72
Cr-Commit-Position: refs/heads/master@{#384395}

[gone, 2016-03-30 00:40:01]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org, yusufo@chromium.org

[gone, 2016-03-30 00:40:02]

Whole lotta testing.  Main functional change is the one in
DocumentModeAssassin#migrateFromDocumentToTabbedMode(), which now gives up after
three attempts.  Probably want to tweak that number to 1 or 2, in the end.

[Ted C, 2016-03-31 03:38:41]

lgtm w/ a couple small comments

https://codereview.chromium.org/1838333003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
(right):

https://codereview.chromium.org/1838333003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:157:
SharedPreferences prefs =
PreferenceManager.getDefaultSharedPreferences(getContext());
does this cause StrictMode violations?  I never recall w/ prefs.

https://codereview.chromium.org/1838333003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:508:
/** DocumentModeAssassin that can has methods that may be overridden for
testing. */
can has?

https://codereview.chromium.org/1838333003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:534:
protected ActivityDelegate getActivityDelegate() {
I would call this createActivityDelegate.  get implies reuse to me

[gone, 2016-03-31 18:07:20]

https://chromiumcodereview.appspot.com/1838333003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
(right):

https://chromiumcodereview.appspot.com/1838333003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:157:
SharedPreferences prefs =
PreferenceManager.getDefaultSharedPreferences(getContext());
On 2016/03/31 03:38:41, Ted C wrote:
> does this cause StrictMode violations?  I never recall w/ prefs.

Didn't seem to... I didn't get any red flashing, at least.

https://chromiumcodereview.appspot.com/1838333003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:508:
/** DocumentModeAssassin that can has methods that may be overridden for
testing. */
On 2016/03/31 03:38:41, Ted C wrote:
> can has?

Totally legit english.

https://chromiumcodereview.appspot.com/1838333003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java:534:
protected ActivityDelegate getActivityDelegate() {
On 2016/03/31 03:38:41, Ted C wrote:
> I would call this createActivityDelegate.  get implies reuse to me

Done.

[gone, 2016-03-31 19:01:02]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-03-31 19:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1838333003/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2016-03-31 19:01:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838333003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838333003/60001

[commit-bot: I haz the power, 2016-03-31 20:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 20:34:35]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2016-03-31 20:36:47]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-03-31 20:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1838333003/#ps80001
(title: "Stupid proguard")

[commit-bot: I haz the power, 2016-03-31 20:37:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838333003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838333003/80001

[commit-bot: I haz the power, 2016-03-31 21:25:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-31 21:28:52]

Description was changed from

==========
Add fallback for DocumentModeAssassin

* Adds a fallback to the DocumentModeAssassin so that it forces the
  user into tabbed mode without their data if migration keeps
  crashing.

* Refactors how the DocumentModeAssassin makes calls to get TabModels
  and Files in order to make more of it testable.

* Adds more tests for the DocumentModeAssassin for testing the full
  pipeline and various ways it can be skipped.

* Length of time to show the UpgradeActivity is upped to 1 second
  to avoid animation jank.

BUG=582539
==========

to

==========
Add fallback for DocumentModeAssassin

* Adds a fallback to the DocumentModeAssassin so that it forces the
  user into tabbed mode without their data if migration keeps
  crashing.

* Refactors how the DocumentModeAssassin makes calls to get TabModels
  and Files in order to make more of it testable.

* Adds more tests for the DocumentModeAssassin for testing the full
  pipeline and various ways it can be skipped.

* Length of time to show the UpgradeActivity is upped to 1 second
  to avoid animation jank.

BUG=582539

Committed: https://crrev.com/1d1b05264afca07e10687e9c79f91df0ff1f2a72
Cr-Commit-Position: refs/heads/master@{#384395}
==========

[commit-bot: I haz the power, 2016-03-31 21:28:53]

Patchset 5 (id:??) landed as
https://crrev.com/1d1b05264afca07e10687e9c79f91df0ff1f2a72
Cr-Commit-Position: refs/heads/master@{#384395}