chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java - Issue 1838333003: Add fallback for DocumentModeAssassin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

Issue 1838333003: Add fallback for DocumentModeAssassin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stupid proguard Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java b/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

index 529bec5ab62f7d8c12bae20eb548b267a3c0dad7..778da0524e7d7ef48272e6c7769938dbe3dd8e3c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

@@ -124,8 +124,12 @@ public class FeatureUtilities {

}

/**

- * Whether the device could possibly run in Document mode (may return true even

- * if the document mode is turned off).

+ * Whether the device could possibly run in Document mode (may return true even if the document

+ * mode is turned off).

+ *

+ * This function can't be changed to return false (even if document mode is deleted) because we

+ * need to know whether a user needs to be migrated away.

+ *

* @param context The context to use for checking configuration.

* @return Whether the device could possibly run in Document mode.