Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: benchmark/lib/dashboard_model.dart

Issue 1829573002: Fix all strong mode warnings in protoc-plugin (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: regenerate pb.dart files Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « benchmark/lib/benchmarks/string_json.dart ('k') | benchmark/lib/dashboard_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: benchmark/lib/dashboard_model.dart
diff --git a/benchmark/lib/dashboard_model.dart b/benchmark/lib/dashboard_model.dart
index 533d0c81fa666aa0e3e83b78665d5aee53ab8a04..a7a658109f99b87b680cfa4a24cd0dcac6702fe6 100644
--- a/benchmark/lib/dashboard_model.dart
+++ b/benchmark/lib/dashboard_model.dart
@@ -40,11 +40,11 @@ class Table {
final Set<pb.Request> selections;
final rows = <Row>[];
- factory Table(pb.Suite suite) =>
- new Table._raw(suite, null, null, new Set<pb.Request>.from(suite.requests));
+ factory Table(pb.Suite suite) => new Table._raw(
+ suite, null, null, new Set<pb.Request>.from(suite.requests));
Table._raw(this.suite, this.baseline, this.report, this.selections) {
- var it = report == null ? [].iterator : report.responses.iterator;
+ Iterator it = report == null ? [].iterator : report.responses.iterator;
for (var r in suite.requests) {
var b = createBenchmark(r);
pb.Sample baseline;
@@ -60,8 +60,8 @@ class Table {
new Table._raw(suite, baseline, report, selections);
Table withAllSelected() {
- return new Table._raw(suite, baseline, report,
- new Set<pb.Request>.from(suite.requests));
+ return new Table._raw(
+ suite, baseline, report, new Set<pb.Request>.from(suite.requests));
}
Table withNoneSelected() {
« no previous file with comments | « benchmark/lib/benchmarks/string_json.dart ('k') | benchmark/lib/dashboard_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698