Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: benchmark/lib/benchmarks/string_json.dart

Issue 1829573002: Fix all strong mode warnings in protoc-plugin (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: regenerate pb.dart files Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « benchmark/lib/benchmarks/set_strings.dart ('k') | benchmark/lib/dashboard_model.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: benchmark/lib/benchmarks/string_json.dart
diff --git a/benchmark/lib/benchmarks/string_json.dart b/benchmark/lib/benchmarks/string_json.dart
index 8e7c06672cbccd637ebb785b906b1ea3feb9b591..7d3cab24d73373c5aa7d22b4c8814fb1479321e8 100644
--- a/benchmark/lib/benchmarks/string_json.dart
+++ b/benchmark/lib/benchmarks/string_json.dart
@@ -86,7 +86,7 @@ class StringBenchmark extends Benchmark {
static const $id = BenchmarkID.READ_STRING_FIELDS_JSON;
static final $type = new BenchmarkType($id, $create);
- static $create(Request r) {
+ static StringBenchmark $create(Request r) {
assert(r.params.hasStringFieldCount());
assert(r.params.hasMessageCount());
assert(r.params.hasStringSize());
« no previous file with comments | « benchmark/lib/benchmarks/set_strings.dart ('k') | benchmark/lib/dashboard_model.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698