Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: benchmark/lib/dashboard_view.dart

Issue 1829573002: Fix all strong mode warnings in protoc-plugin (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: regenerate pb.dart files Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « benchmark/lib/dashboard_model.dart ('k') | bin/protoc_plugin_bazel.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: benchmark/lib/dashboard_view.dart
diff --git a/benchmark/lib/dashboard_view.dart b/benchmark/lib/dashboard_view.dart
index 011192ab406085d82794fa555c591606c422b156..9b56e64cfa7cea892c09a9a1ed5a38e001942b4e 100644
--- a/benchmark/lib/dashboard_view.dart
+++ b/benchmark/lib/dashboard_view.dart
@@ -73,7 +73,7 @@ Choose baseline: <select class="dv-menu"></select>
this._jsonView);
factory DashboardView() {
- var elt = _template.clone(true);
+ Element elt = _template.clone(true);
find(String q) => elt.querySelector(q);
_Button button(q) => new _Button(find(q));
label(q) => new _Label(find(q));
@@ -97,7 +97,7 @@ Choose baseline: <select class="dv-menu"></select>
Stream get onSelectAllClick => _selectAllButton.onClick;
Stream get onSelectNoneClick => _selectNoneButton.onClick;
Stream<String> get onMenuChange =>
- _menu.onChange.map((item) => item == noBaseline ? null : item);
+ _menu.onChange.map((item) => item == noBaseline ? null : item);
Stream<SelectEvent<pb.Request>> get onSelectionChange =>
_selectionChanges.stream;
@@ -176,8 +176,8 @@ class _ResponseView {
]);
}
- void render(Row row, pb.Report r,
- EventSink<SelectEvent<pb.Request>> rowSelected) {
+ void render(
+ Row row, pb.Report r, EventSink<SelectEvent<pb.Request>> rowSelected) {
var b = row.benchmark;
var response = row.findResponse(r);
_selected.render(row.selected, item: row.request, sink: rowSelected);
@@ -235,7 +235,7 @@ class _JsonView {
/// A menu of selectable text items.
class _Menu {
final SelectElement elt;
- final _changes = new StreamController.broadcast();
+ final _changes = new StreamController<String>.broadcast();
final _options = new List<_MenuOption>();
_Menu(this.elt) {
« no previous file with comments | « benchmark/lib/dashboard_model.dart ('k') | bin/protoc_plugin_bazel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698