Fix all strong mode warnings in protoc-plugin

benchmark/lib/dashboard_view.dart

Index: benchmark/lib/dashboard_view.dart
diff --git a/benchmark/lib/dashboard_view.dart b/benchmark/lib/dashboard_view.dart
index 011192ab406085d82794fa555c591606c422b156..a1010dc2860f4b17b55aaecd3f1cd94428e048eb 100644
--- a/benchmark/lib/dashboard_view.dart
+++ b/benchmark/lib/dashboard_view.dart
@@ -73,7 +73,7 @@ Choose baseline: <select class="dv-menu"></select>
       this._jsonView);
 
   factory DashboardView() {
-    var elt = _template.clone(true);
+    Element elt = _template.clone(true);
     find(String q) => elt.querySelector(q);
     _Button button(q) => new _Button(find(q));
     label(q) => new _Label(find(q));
@@ -97,7 +97,8 @@ Choose baseline: <select class="dv-menu"></select>
   Stream get onSelectAllClick => _selectAllButton.onClick;
   Stream get onSelectNoneClick => _selectNoneButton.onClick;
   Stream<String> get onMenuChange =>
-    _menu.onChange.map((item) => item == noBaseline ? null : item);
+      _menu.onChange.map((item) => item == noBaseline ? null : item)

[vsm, 2016/03/23 17:20:24]

Stream.map is a generic method.  Strong mode will try to infer the type, but
it's failing here.

Can you try map<String>(...) and dropping the cast?  The cast will fail at
runtime in DDC (it'd try to cast Stream<Object> to Stream<String>).

[Leaf, 2016/03/23 18:09:59]

I don't understand why inference is failing here.  In a standalone repro it
works.  What version are you using?  Command line or Intellij?  There's an
intellij regression in 1.16.0.dev-2.0 that breaks strong mode generics - be sure
you're not using that.

[skybrian, 2016/03/23 18:34:17]

I'm using Atom with an SDK built at HEAD. I think this is another instance of:
https://github.com/dart-lang/sdk/issues/26062

Hopefully by the time I get back to this CL it will be fixed.

[skybrian, 2016/04/01 02:00:15]

It works now. Reverted.

+      as Stream<String>;
   Stream<SelectEvent<pb.Request>> get onSelectionChange =>
       _selectionChanges.stream;
 
@@ -176,8 +177,8 @@ class _ResponseView {
     ]);
   }
 
-  void render(Row row, pb.Report r,
-      EventSink<SelectEvent<pb.Request>> rowSelected) {
+  void render(
+      Row row, pb.Report r, EventSink<SelectEvent<pb.Request>> rowSelected) {
     var b = row.benchmark;
     var response = row.findResponse(r);
     _selected.render(row.selected, item: row.request, sink: rowSelected);
@@ -242,7 +243,7 @@ class _Menu {
     elt.onChange.listen((e) => _changes.add(elt.value));
   }
 
-  Stream<String> get onChange => _changes.stream;
+  Stream<String> get onChange => _changes.stream as Stream<String>;

[vsm, 2016/03/23 17:20:24]

This will fail at runtime if the runtime type of _changes.stream is not a
Stream<String>.  Instead, I think we need above:

final _changes = new StreamController<String>.broadcast();

and drop the cast.

[Leaf, 2016/03/23 18:09:59]

Agreed.

[skybrian, 2016/04/01 02:00:15]

Done

 
   void render(List<String> items, String selected) {
     var it = items.iterator;