Fix all strong mode warnings in protoc-plugin

benchmark/lib/dashboard_model.dart

Index: benchmark/lib/dashboard_model.dart
diff --git a/benchmark/lib/dashboard_model.dart b/benchmark/lib/dashboard_model.dart
index 533d0c81fa666aa0e3e83b78665d5aee53ab8a04..a7a658109f99b87b680cfa4a24cd0dcac6702fe6 100644
--- a/benchmark/lib/dashboard_model.dart
+++ b/benchmark/lib/dashboard_model.dart
@@ -40,11 +40,11 @@ class Table {
   final Set<pb.Request> selections;
   final rows = <Row>[];
 
-  factory Table(pb.Suite suite) =>
-    new Table._raw(suite, null, null, new Set<pb.Request>.from(suite.requests));
+  factory Table(pb.Suite suite) => new Table._raw(
+      suite, null, null, new Set<pb.Request>.from(suite.requests));
 
   Table._raw(this.suite, this.baseline, this.report, this.selections) {
-    var it = report == null ? [].iterator : report.responses.iterator;
+    Iterator it = report == null ? [].iterator : report.responses.iterator;

[vsm, 2016/03/23 17:20:24]

Interesting that we're not inferring this type.

[Leaf, 2016/03/23 18:09:59]

Probably LUB.

[skybrian, 2016/04/01 02:00:15]

What does LUB mean?

[Leaf, 2016/04/01 18:13:51]

Sorry - Least Upper Bound.  Dart's least upper bound computation isn't very
useful to us, and often gives surprising results.  I've recently checked in
something which fixes the low-hanging fruit - you could try and see if we now
infer a useful type.

     for (var r in suite.requests) {
       var b = createBenchmark(r);
       pb.Sample baseline;
@@ -60,8 +60,8 @@ class Table {
       new Table._raw(suite, baseline, report, selections);
 
   Table withAllSelected() {
-    return new Table._raw(suite, baseline, report,
-      new Set<pb.Request>.from(suite.requests));
+    return new Table._raw(
+        suite, baseline, report, new Set<pb.Request>.from(suite.requests));
   }
 
   Table withNoneSelected() {