Fix all strong mode warnings in protoc-plugin

benchmark/lib/dashboard_view.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protoc.benchmark.html_view;
 
 import 'dart:async' show Stream, StreamController, EventSink;
 import 'dart:html';
 
 import 'generated/benchmark.pb.dart' as pb;
@@ skipping 55 matching lines @@
       this._runButton,
       this._selectAllButton,
       this._selectNoneButton,
       this._status,
       this._envElt,
       this._menu,
       this._responseTable,
       this._jsonView);
 
   factory DashboardView() {
-    var elt = _template.clone(true);
+    Element elt = _template.clone(true);
     find(String q) => elt.querySelector(q);
     _Button button(q) => new _Button(find(q));
     label(q) => new _Label(find(q));
     menu(q) => new _Menu(find(q));
     json(q) => new _JsonView(find(q));
     return new DashboardView._raw(
         elt,
         button('.dv-run')
           ..elt.style.color = "#FFFFFF"
           ..elt.style.backgroundColor = "rgb(209, 72, 64)",
         button('.dv-select-all'),
         button('.dv-select-none'),
         label('.dv-status'),
         find('.dv-env'),
         menu('.dv-menu'),
         find('.dv-table'),
         json('.dv-json'));
   }
 
   Stream get onRunButtonClick => _runButton.onClick;
   Stream get onSelectAllClick => _selectAllButton.onClick;
   Stream get onSelectNoneClick => _selectNoneButton.onClick;
   Stream<String> get onMenuChange =>
-    _menu.onChange.map((item) => item == noBaseline ? null : item);
+      _menu.onChange.map((item) => item == noBaseline ? null : item)

[vsm, 2016/03/23 17:20:24]

Stream.map is a generic method.  Strong mode will try to infer the type, but
it's failing here.

Can you try map<String>(...) and dropping the cast?  The cast will fail at
runtime in DDC (it'd try to cast Stream<Object> to Stream<String>).

[Leaf, 2016/03/23 18:09:59]

I don't understand why inference is failing here.  In a standalone repro it
works.  What version are you using?  Command line or Intellij?  There's an
intellij regression in 1.16.0.dev-2.0 that breaks strong mode generics - be sure
you're not using that.

[skybrian, 2016/03/23 18:34:17]

I'm using Atom with an SDK built at HEAD. I think this is another instance of:
https://github.com/dart-lang/sdk/issues/26062

Hopefully by the time I get back to this CL it will be fixed.

[skybrian, 2016/04/01 02:00:15]

It works now. Reverted.

+      as Stream<String>;
   Stream<SelectEvent<pb.Request>> get onSelectionChange =>
       _selectionChanges.stream;
 
   void render(DashboardModel model) {
     _runButton.render("Run", model.canRun);
     _selectAllButton.render("Select All", true);
     _selectNoneButton.render("Select None", true);
     if (!model.latest.hasStatus() || model.latest.status == pb.Status.DONE) {
       _status.render("");
     } else {
@@ skipping 58 matching lines @@
       _selected.elt,
       _summary.elt,
       _baseline.elt,
       _median.elt,
       _max.elt,
       _count.elt,
       _units.elt
     ]);
   }
 
-  void render(Row row, pb.Report r,
-      EventSink<SelectEvent<pb.Request>> rowSelected) {
+  void render(
+      Row row, pb.Report r, EventSink<SelectEvent<pb.Request>> rowSelected) {
     var b = row.benchmark;
     var response = row.findResponse(r);
     _selected.render(row.selected, item: row.request, sink: rowSelected);
     _summary.render(b.summary);
     _baseline.render(b.measureSample(row.baseline));
     _median.render(b.measureSample(b.medianSample(response)));
     _max.render(b.measureSample(b.maxSample(response)));
     _count.render(response == null ? "0" : "${response.samples.length}");
     _units.render(row.benchmark.measureSampleUnits);
   }
@@ skipping 44 matching lines @@
 /// A menu of selectable text items.
 class _Menu {
   final SelectElement elt;
   final _changes = new StreamController.broadcast();
   final _options = new List<_MenuOption>();
 
   _Menu(this.elt) {
     elt.onChange.listen((e) => _changes.add(elt.value));
   }
 
-  Stream<String> get onChange => _changes.stream;
+  Stream<String> get onChange => _changes.stream as Stream<String>;

[vsm, 2016/03/23 17:20:24]

This will fail at runtime if the runtime type of _changes.stream is not a
Stream<String>.  Instead, I think we need above:

final _changes = new StreamController<String>.broadcast();

and drop the cast.

[Leaf, 2016/03/23 18:09:59]

Agreed.

[skybrian, 2016/04/01 02:00:15]

Done

 
   void render(List<String> items, String selected) {
     var it = items.iterator;
 
     // Update existing items
     for (var opt in _options) {
       var hasNext = it.moveNext();
       assert(hasNext); // assume menu never shrinks
       opt.render(it.current, it.current == selected);
     }
@@ skipping 79 matching lines @@
 
   void render(bool checked, {EventSink<SelectEvent<T>> sink, T item}) {
     if (_renderedChecked != checked) {
       elt.checked = checked;
       _renderedChecked = checked;
     }
     _item = item;
     _sink = sink;
   }
 }