Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 17956002: Don't set MIPS specific target arch CFLAGS for android WebView (Closed)

Created:
7 years, 6 months ago by benm (inactive)
Modified:
7 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Don't set MIPS specific target arch CFLAGS for android WebView These flags are set by the android build system in the case of an android webview build, so don't attempt to reset them. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208907

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : torne's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/common.gypi View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benm (inactive)
ptal, i think this is what we want?
7 years, 6 months ago (2013-06-26 22:40:21 UTC) #1
Torne
https://codereview.chromium.org/17956002/diff/2001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/17956002/diff/2001/build/common.gypi#newcode1333 build/common.gypi:1333: 'mips_arch_variant': '', Do we need to touch this given ...
7 years, 6 months ago (2013-06-26 22:41:51 UTC) #2
benm (inactive)
thanks torne, running a test build locally https://codereview.chromium.org/17956002/diff/2001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/17956002/diff/2001/build/common.gypi#newcode1333 build/common.gypi:1333: 'mips_arch_variant': '', ...
7 years, 6 months ago (2013-06-26 22:50:47 UTC) #3
Torne
lgtm
7 years, 6 months ago (2013-06-26 22:53:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/17956002/7001
7 years, 6 months ago (2013-06-27 00:00:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/17956002/7001
7 years, 5 months ago (2013-06-27 06:51:07 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 12:58:43 UTC) #7
Message was sent while issue was closed.
Change committed as 208907

Powered by Google App Engine
This is Rietveld 408576698