build/common.gypi - Issue 17956002: Don't set MIPS specific target arch CFLAGS for android WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 17956002: Don't set MIPS specific target arch CFLAGS for android WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: torne's comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 3fd1c770b6b7ad08d5c4f8574fcd3b71c2d7aff0..f812eba4151f03b160510003f41874f6efaea2b8 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3043,9 +3043,10 @@

'target_conditions': [

['_toolset=="target"', {

'conditions': [

- ['mips_arch_variant=="mips32r2"', {

+ ['android_webview_build==0 and mips_arch_variant=="mips32r2"', {

'cflags': ['-mips32r2', '-Wa,-mips32r2'],

- }, {

+ }],

+ ['android_webview_build==0 and mips_arch_variant!="mips32r2"', {

'cflags': ['-mips32', '-Wa,-mips32'],

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »