Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Side by Side Diff: build/common.gypi

Issue 17956002: Don't set MIPS specific target arch CFLAGS for android WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: torne's comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3025 matching lines...) Expand 10 before | Expand all | Expand 10 after
3036 ], 3036 ],
3037 }], 3037 }],
3038 ], 3038 ],
3039 }], 3039 }],
3040 ], 3040 ],
3041 }], 3041 }],
3042 ['target_arch=="mipsel"', { 3042 ['target_arch=="mipsel"', {
3043 'target_conditions': [ 3043 'target_conditions': [
3044 ['_toolset=="target"', { 3044 ['_toolset=="target"', {
3045 'conditions': [ 3045 'conditions': [
3046 ['mips_arch_variant=="mips32r2"', { 3046 ['android_webview_build==0 and mips_arch_variant=="mips32r2"', {
3047 'cflags': ['-mips32r2', '-Wa,-mips32r2'], 3047 'cflags': ['-mips32r2', '-Wa,-mips32r2'],
3048 }, { 3048 }],
3049 ['android_webview_build==0 and mips_arch_variant!="mips32r2"', {
3049 'cflags': ['-mips32', '-Wa,-mips32'], 3050 'cflags': ['-mips32', '-Wa,-mips32'],
3050 }], 3051 }],
3051 ], 3052 ],
3052 'cflags': [ 3053 'cflags': [
3053 '-EL', 3054 '-EL',
3054 '-mhard-float', 3055 '-mhard-float',
3055 ], 3056 ],
3056 'ldflags': [ 3057 'ldflags': [
3057 '-EL', 3058 '-EL',
3058 '-Wl,--no-keep-memory' 3059 '-Wl,--no-keep-memory'
(...skipping 1534 matching lines...) Expand 10 before | Expand all | Expand 10 after
4593 # settings in target dicts. SYMROOT is a special case, because many other 4594 # settings in target dicts. SYMROOT is a special case, because many other
4594 # Xcode variables depend on it, including variables such as 4595 # Xcode variables depend on it, including variables such as
4595 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4596 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4596 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4597 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4597 # files to appear (when present) in the UI as actual files and not red 4598 # files to appear (when present) in the UI as actual files and not red
4598 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4599 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4599 # and therefore SYMROOT, needs to be set at the project level. 4600 # and therefore SYMROOT, needs to be set at the project level.
4600 'SYMROOT': '<(DEPTH)/xcodebuild', 4601 'SYMROOT': '<(DEPTH)/xcodebuild',
4601 }, 4602 },
4602 } 4603 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698