chrome/browser/safe_browsing/download_feedback_unittest.cc - Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_unittest.cc

Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_service_unittest.cc ('k') | chrome/browser/ssl/ssl_client_certificate_selector_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_unittest.cc b/chrome/browser/safe_browsing/download_feedback_unittest.cc

index 4a83868975c95a015fabd57823e859d8c9a2d552..0054a693c47c9c0066dcb395456a78d46a1630d7 100644

--- a/chrome/browser/safe_browsing/download_feedback_unittest.cc

+++ b/chrome/browser/safe_browsing/download_feedback_unittest.cc

@@ -169,12 +169,12 @@ TEST_F(DownloadFeedbackTest, CompleteUpload) {

CommandLine::ForCurrentProcess()->AppendSwitchASCII(

switches::kSbDownloadFeedbackURL, kTestFeedbackURL);

- DownloadFeedback* feedback = DownloadFeedback::Create(

- url_request_context_getter_,

- file_task_runner_,

- upload_file_path_,

- ping_request,

- ping_response);

+ DownloadFeedback* feedback =

+ DownloadFeedback::Create(url_request_context_getter_.get(),

+ file_task_runner_.get(),

+ upload_file_path_,

+ ping_request,

+ ping_response);

EXPECT_FALSE(uploader());

feedback->Start(base::Bind(&DownloadFeedbackTest::FinishCallback,

@@ -216,12 +216,12 @@ TEST_F(DownloadFeedbackTest, CancelUpload) {

std::string ping_response(

expected_report_metadata.download_response().SerializeAsString());