Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/safe_browsing/download_feedback_unittest.cc

Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/download_feedback.h" 5 #include "chrome/browser/safe_browsing/download_feedback.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 ClientDownloadResponse::DANGEROUS_HOST); 162 ClientDownloadResponse::DANGEROUS_HOST);
163 std::string ping_request( 163 std::string ping_request(
164 expected_report_metadata.download_request().SerializeAsString()); 164 expected_report_metadata.download_request().SerializeAsString());
165 std::string ping_response( 165 std::string ping_response(
166 expected_report_metadata.download_response().SerializeAsString()); 166 expected_report_metadata.download_response().SerializeAsString());
167 167
168 const char kTestFeedbackURL[] = "https://example.com/test/upload"; 168 const char kTestFeedbackURL[] = "https://example.com/test/upload";
169 CommandLine::ForCurrentProcess()->AppendSwitchASCII( 169 CommandLine::ForCurrentProcess()->AppendSwitchASCII(
170 switches::kSbDownloadFeedbackURL, kTestFeedbackURL); 170 switches::kSbDownloadFeedbackURL, kTestFeedbackURL);
171 171
172 DownloadFeedback* feedback = DownloadFeedback::Create( 172 DownloadFeedback* feedback =
173 url_request_context_getter_, 173 DownloadFeedback::Create(url_request_context_getter_.get(),
174 file_task_runner_, 174 file_task_runner_.get(),
175 upload_file_path_, 175 upload_file_path_,
176 ping_request, 176 ping_request,
177 ping_response); 177 ping_response);
178 EXPECT_FALSE(uploader()); 178 EXPECT_FALSE(uploader());
179 179
180 feedback->Start(base::Bind(&DownloadFeedbackTest::FinishCallback, 180 feedback->Start(base::Bind(&DownloadFeedbackTest::FinishCallback,
181 base::Unretained(this), 181 base::Unretained(this),
182 feedback)); 182 feedback));
183 ASSERT_TRUE(uploader()); 183 ASSERT_TRUE(uploader());
184 EXPECT_FALSE(feedback_finish_called_); 184 EXPECT_FALSE(feedback_finish_called_);
185 EXPECT_TRUE(uploader()->start_called_); 185 EXPECT_TRUE(uploader()->start_called_);
186 186
187 EXPECT_EQ(url_request_context_getter_, 187 EXPECT_EQ(url_request_context_getter_,
(...skipping 21 matching lines...) Expand all
209 upload_file_data_.size()); 209 upload_file_data_.size());
210 expected_report_metadata.mutable_download_request()->mutable_digests( 210 expected_report_metadata.mutable_download_request()->mutable_digests(
211 )->set_sha1("hi"); 211 )->set_sha1("hi");
212 expected_report_metadata.mutable_download_response()->set_verdict( 212 expected_report_metadata.mutable_download_response()->set_verdict(
213 ClientDownloadResponse::DANGEROUS_HOST); 213 ClientDownloadResponse::DANGEROUS_HOST);
214 std::string ping_request( 214 std::string ping_request(
215 expected_report_metadata.download_request().SerializeAsString()); 215 expected_report_metadata.download_request().SerializeAsString());
216 std::string ping_response( 216 std::string ping_response(
217 expected_report_metadata.download_response().SerializeAsString()); 217 expected_report_metadata.download_response().SerializeAsString());
218 218
219 DownloadFeedback* feedback = DownloadFeedback::Create( 219 DownloadFeedback* feedback =
220 url_request_context_getter_, 220 DownloadFeedback::Create(url_request_context_getter_.get(),
221 file_task_runner_, 221 file_task_runner_.get(),
222 upload_file_path_, 222 upload_file_path_,
223 ping_request, 223 ping_request,
224 ping_response); 224 ping_response);
225 EXPECT_FALSE(uploader()); 225 EXPECT_FALSE(uploader());
226 226
227 feedback->Start(base::Bind(&DownloadFeedbackTest::FinishCallback, 227 feedback->Start(base::Bind(&DownloadFeedbackTest::FinishCallback,
228 base::Unretained(this), 228 base::Unretained(this),
229 feedback)); 229 feedback));
230 ASSERT_TRUE(uploader()); 230 ASSERT_TRUE(uploader());
231 EXPECT_FALSE(feedback_finish_called_); 231 EXPECT_FALSE(feedback_finish_called_);
232 EXPECT_TRUE(uploader()->start_called_); 232 EXPECT_TRUE(uploader()->start_called_);
233 EXPECT_TRUE(file_util::PathExists(upload_file_path_)); 233 EXPECT_TRUE(file_util::PathExists(upload_file_path_));
234 234
235 delete feedback; 235 delete feedback;
236 EXPECT_FALSE(feedback_finish_called_); 236 EXPECT_FALSE(feedback_finish_called_);
237 237
238 base::RunLoop().RunUntilIdle(); 238 base::RunLoop().RunUntilIdle();
239 EXPECT_FALSE(file_util::PathExists(upload_file_path_)); 239 EXPECT_FALSE(file_util::PathExists(upload_file_path_));
240 } 240 }
241 241
242 } // namespace safe_browsing 242 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698