chrome/browser/safe_browsing/download_feedback_service_unittest.cc - Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_service.cc ('k') | chrome/browser/safe_browsing/download_feedback_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

index 8f0a8743949322f593f76b7b695206cded0e0436..a912a3f7f0794d86d5b831803f6c7720e4d052db 100644

--- a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

@@ -208,7 +208,8 @@ TEST_F(DownloadFeedbackServiceTest, SingleFeedbackComplete) {

EXPECT_CALL(item, StealDangerousDownload(_))

.WillOnce(SaveArg<0>(&download_discarded_callback));

- DownloadFeedbackService service(request_context_getter_, file_task_runner_);

+ DownloadFeedbackService service(request_context_getter_.get(),

+ file_task_runner_.get());

service.MaybeStorePingsForDownload(

DownloadProtectionService::UNCOMMON, &item, ping_request, ping_response);

ASSERT_TRUE(DownloadFeedbackService::IsEnabledForDownload(item));

@@ -255,7 +256,8 @@ TEST_F(DownloadFeedbackServiceTest, MultiplePendingFeedbackComplete) {

}

{

- DownloadFeedbackService service(request_context_getter_, file_task_runner_);

+ DownloadFeedbackService service(request_context_getter_.get(),

+ file_task_runner_.get());

for (size_t i = 0; i < num_downloads; ++i) {

SCOPED_TRACE(i);

service.BeginFeedbackForDownload(&item[i]);

@@ -323,7 +325,8 @@ TEST_F(DownloadFeedbackServiceTest, MultiFeedbackWithIncomplete) {

}

{

- DownloadFeedbackService service(request_context_getter_, file_task_runner_);

+ DownloadFeedbackService service(request_context_getter_.get(),

+ file_task_runner_.get());

for (size_t i = 0; i < num_downloads; ++i) {

SCOPED_TRACE(i);

service.BeginFeedbackForDownload(&item[i]);