Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 17948002: Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 5 months ago
CC:
chromium-reviews, felt, tzik+watch_chromium.org, ahutter, gavinp+memory_chromium.org, stuartmorgan+watch_chromium.org, Albert Bodenhamer, kinuko+watch, native-client-reviews_googlegroups.com, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benquan, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dbeam+watch-options_chromium.org, feature-media-reviews_chromium.org, Raman Kakilate, rouslan+autofillwatch_chromium.org, michaeln, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Update Linux to use scoped_refptr<T>::get() rather than implicit "operator T*" Fixes a number of cases either not caught by the automated tool or that have recently regressed. BUG=206189 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208882

Patch Set 1 #

Patch Set 2 : Without tuple changes #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -282 lines) Patch
M apps/shortcut_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/ref_counted_delete_on_message_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 8 chunks +44 lines, -41 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_file_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/policy_service_impl_unittest.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/sync_type_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M components/webdata/common/web_database_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_network_proxy_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/webmessageportchannel_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M content/worker/websharedworker_stub.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_array_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_cert_database.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_cert_database.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cert/test_root_certs_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/cert/x509_certificate.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/x509_certificate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/disk_cache/block_files.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream_job.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_ref_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_url_request_job.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/browser/blob/blob_storage_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_quota_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/timed_task_helper_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-26 22:27:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/17948002/2001
7 years, 6 months ago (2013-06-26 22:27:26 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/browser/in_process_webkit/indexed_db_browsertest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 6 months ago (2013-06-26 22:27:49 UTC) #3
darin (slow to review)
rubber stamp LGTM
7 years, 6 months ago (2013-06-26 22:47:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/17948002/6001
7 years, 6 months ago (2013-06-26 22:49:04 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 10:36:16 UTC) #6
Message was sent while issue was closed.
Change committed as 208882

Powered by Google App Engine
This is Rietveld 408576698