Remove committer list, bugzilla, watchlist code and transitive closure of stuff.

Remove committer list, bugzilla, watchlist code and transitive closure of stuff.

I started off by wanting to delete the committer list code. Pulling on one
thread after another led me to delete all the code I found dealing w/
changelogs, commitinfo's, bugzilla, and watchlists, and deleting a bunch
of the associated commands and steps.

Hopefully none of this stuff is needed anywhere else. test-webkitpy passes,
at least.

R=abarth@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153027

[abarth-chromium, 2013-06-25 04:52:18]

LGTM

You can also remove QueueEngine and everything that depends on it.  :)

[commit-bot: I haz the power, 2013-06-25 18:59:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/17639006/1

[commit-bot: I haz the power, 2013-06-25 20:22:46]

Failed to apply patch for Tools/Scripts/webkitpy/common/checkout/checkout.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/Scripts/webkitpy/common/checkout/checkout.py
  Hunk #1 FAILED at 29.
  Hunk #2 FAILED at 47.
  Hunk #3 FAILED at 111.
  Hunk #4 FAILED at 143.
  4 out of 4 hunks FAILED -- saving rejects to file
Tools/Scripts/webkitpy/common/checkout/checkout.py.rej

Patch:       Tools/Scripts/webkitpy/common/checkout/checkout.py
Index: Tools/Scripts/webkitpy/common/checkout/checkout.py
diff --git a/Tools/Scripts/webkitpy/common/checkout/checkout.py
b/Tools/Scripts/webkitpy/common/checkout/checkout.py
index
165ff4ebf8a5b9adc4d0abeae69a40563955077c..6b640d0d3c48a9ad4a6ec9baa3c1c59846beb179
100644
--- a/Tools/Scripts/webkitpy/common/checkout/checkout.py
+++ b/Tools/Scripts/webkitpy/common/checkout/checkout.py
@@ -29,16 +29,13 @@
 import StringIO
 
 from webkitpy.common.config import urls
-from webkitpy.common.checkout.changelog import ChangeLog,
parse_bug_id_from_changelog
-from webkitpy.common.checkout.commitinfo import CommitInfo
 from webkitpy.common.checkout.scm import CommitMessage
 from webkitpy.common.checkout.deps import DEPS
 from webkitpy.common.memoized import memoized
 from webkitpy.common.system.executive import ScriptError
 
 
-# This class represents the WebKit-specific parts of the checkout (like
ChangeLogs).
-# FIXME: Move a bunch of ChangeLog-specific processing from SCM to this object.
+# This class represents the WebKit-specific parts of the checkout.
 # NOTE: All paths returned from this class should be absolute.
 class Checkout(object):
     def __init__(self, scm, executive=None, filesystem=None):
@@ -47,62 +44,6 @@ class Checkout(object):
         self._executive = executive or self._scm._executive
         self._filesystem = filesystem or self._scm._filesystem
 
-    def is_path_to_changelog(self, path):
-        return self._filesystem.basename(path) == "ChangeLog"
-
-    def _latest_entry_for_changelog_at_revision(self, changelog_path,
revision):
-        changelog_contents = self._scm.contents_at_revision(changelog_path,
revision)
-        # contents_at_revision returns a byte array (str()), but we know
-        # that ChangeLog files are utf-8.  parse_latest_entry_from_file
-        # expects a file-like object which vends unicode(), so we decode here.
-        # Old revisions of Sources/WebKit/wx/ChangeLog have some invalid utf8
characters.
-        changelog_file = StringIO.StringIO(changelog_contents.decode("utf-8",
"ignore"))
-        return ChangeLog.parse_latest_entry_from_file(changelog_file)
-
-    def changelog_entries_for_revision(self, revision, changed_files=None):
-        if not changed_files:
-            changed_files = self._scm.changed_files_for_revision(revision)
-        # FIXME: This gets confused if ChangeLog files are moved, as
-        # deletes are still "changed files" per changed_files_for_revision.
-        # FIXME: For now we hack around this by caching any exceptions
-        # which result from having deleted files included the changed_files
list.
-        changelog_entries = []
-        for path in changed_files:
-            if not self.is_path_to_changelog(path):
-                continue
-            try:
-               
changelog_entries.append(self._latest_entry_for_changelog_at_revision(path,
revision))
-            except ScriptError:
-                pass
-        return changelog_entries
-
-    def _changelog_data_for_revision(self, revision):
-        changed_files = self._scm.changed_files_for_revision(revision)
-        changelog_entries = self.changelog_entries_for_revision(revision,
changed_files=changed_files)
-        # Assume for now that the first entry has everything we need:
-        # FIXME: This will throw an exception if there were no ChangeLogs.
-        if not len(changelog_entries):
-            return None
-        changelog_entry = changelog_entries[0]
-        return {
-            "bug_id": parse_bug_id_from_changelog(changelog_entry.contents()),
-            "author_name": changelog_entry.author_name(),
-            "author_email": changelog_entry.author_email(),
-            "author": changelog_entry.author(),
-            "reviewer_text": changelog_entry.reviewer_text(),
-            "reviewer": changelog_entry.reviewer(),
-            "contents": changelog_entry.contents(),
-            "changed_files": changed_files,
-        }
-
-    @memoized
-    def commit_info_for_revision(self, revision):
-        committer_email = self._scm.committer_email_for_revision(revision)
-        changelog_data = self._changelog_data_for_revision(revision)
-        if not changelog_data:
-            return None
-        return CommitInfo(revision, committer_email, changelog_data)
-
     def _modified_files_matching_predicate(self, git_commit, predicate,
changed_files=None):
         # SCM returns paths relative to scm.checkout_root
         # Callers (especially those using the ChangeLog class) may
@@ -111,21 +52,6 @@ class Checkout(object):
             changed_files = self._scm.changed_files(git_commit)
         return filter(predicate, map(self._scm.absolute_path, changed_files))
 
-    def modified_changelogs(self, git_commit, changed_files=None):
-        return self._modified_files_matching_predicate(git_commit,
self.is_path_to_changelog, changed_files=changed_files)
-
-    def modified_non_changelogs(self, git_commit, changed_files=None):
-        return self._modified_files_matching_predicate(git_commit, lambda path:
not self.is_path_to_changelog(path), changed_files=changed_files)
-
-    def commit_message_for_this_commit(self, git_commit, changed_files=None,
return_stderr=False):
-        changelog_paths = self.modified_changelogs(git_commit, changed_files)
-        if not len(changelog_paths):
-            raise ScriptError(message="Found no modified ChangeLogs, cannot
create a commit message.\n"
-                              "All changes require a ChangeLog.  See:\n %s" %
urls.contribution_guidelines)
-
-        message_text =
self._scm.run([self._scm.script_path('commit-log-editor'), '--print-log'] +
changelog_paths, return_stderr=return_stderr)
-        return CommitMessage(message_text.splitlines())
-
     def recent_commit_infos_for_files(self, paths):
         revisions = set(sum(map(self._scm.revisions_changing_file, paths), []))
         return set(map(self.commit_info_for_revision, revisions))
@@ -143,12 +69,6 @@ class Checkout(object):
     def apply_reverse_diff(self, revision):
         self._scm.apply_reverse_diff(revision)
 
-        # We revert the ChangeLogs because removing lines from a ChangeLog
-        # doesn't make sense.  ChangeLogs are append only.
-        changelog_paths = self.modified_changelogs(git_commit=None)
-        if len(changelog_paths):
-            self._scm.revert_files(changelog_paths)
-
         conflicts = self._scm.conflicted_files()
         if len(conflicts):
             raise ScriptError(message="Failed to apply reverse diff for
revision %s because of the following conflicts:\n%s" % (revision,
"\n".join(conflicts)))

[Dirk Pranke, 2013-06-25 21:32:00]

Committed patchset #2 manually as r153027 (presubmit successful).