Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Side by Side Diff: Tools/Scripts/webkitpy/style/checker_unittest.py

Issue 17639006: Remove committer list, bugzilla, watchlist code and transitive closure of stuff. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge on top of thakis' change in r153020 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # -*- coding: utf-8; -*- 1 # -*- coding: utf-8; -*-
2 # 2 #
3 # Copyright (C) 2009 Google Inc. All rights reserved. 3 # Copyright (C) 2009 Google Inc. All rights reserved.
4 # Copyright (C) 2009 Torch Mobile Inc. 4 # Copyright (C) 2009 Torch Mobile Inc.
5 # Copyright (C) 2009 Apple Inc. All rights reserved. 5 # Copyright (C) 2009 Apple Inc. All rights reserved.
6 # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com) 6 # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com)
7 # 7 #
8 # Redistribution and use in source and binary forms, with or without 8 # Redistribution and use in source and binary forms, with or without
9 # modification, are permitted provided that the following conditions are 9 # modification, are permitted provided that the following conditions are
10 # met: 10 # met:
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 # drawn from the _SKIPPED_FILES_WITHOUT_WARNING configuration 349 # drawn from the _SKIPPED_FILES_WITHOUT_WARNING configuration
350 # variable. 350 # variable.
351 path = os.path.join('LayoutTests', 'foo.txt') 351 path = os.path.join('LayoutTests', 'foo.txt')
352 self._assert_should_skip_without_warning(path, 352 self._assert_should_skip_without_warning(path,
353 is_checker_none=False, 353 is_checker_none=False,
354 expected=True) 354 expected=True)
355 355
356 def test_should_skip_without_warning__false(self): 356 def test_should_skip_without_warning__false(self):
357 """Test should_skip_without_warning() for False return values.""" 357 """Test should_skip_without_warning() for False return values."""
358 paths = ['foo.txt', 358 paths = ['foo.txt',
359 os.path.join('LayoutTests', 'TestExpectations'),
359 ] 360 ]
360 361
361 for path in paths: 362 for path in paths:
362 self._assert_should_skip_without_warning(path, 363 self._assert_should_skip_without_warning(path,
363 is_checker_none=False, 364 is_checker_none=False,
364 expected=False) 365 expected=False)
365 366
366 367
367 class CheckerDispatcherCarriageReturnTest(unittest.TestCase): 368 class CheckerDispatcherCarriageReturnTest(unittest.TestCase):
368 def test_should_check_and_strip_carriage_returns(self): 369 def test_should_check_and_strip_carriage_returns(self):
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 """Test that carriage returns aren't stripped from files that are allowe d to contain them.""" 860 """Test that carriage returns aren't stripped from files that are allowe d to contain them."""
860 file_path = 'carriage_returns_allowed.txt' 861 file_path = 'carriage_returns_allowed.txt'
861 lines = ['line1\r', 'line2\r'] 862 lines = ['line1\r', 'line2\r']
862 line_numbers = [100] 863 line_numbers = [100]
863 self._processor.process(lines=lines, 864 self._processor.process(lines=lines,
864 file_path=file_path, 865 file_path=file_path,
865 line_numbers=line_numbers) 866 line_numbers=line_numbers)
866 # The carriage return checker should never have been invoked, and so 867 # The carriage return checker should never have been invoked, and so
867 # should not have saved off any lines. 868 # should not have saved off any lines.
868 self.assertFalse(hasattr(self.carriage_checker, 'lines')) 869 self.assertFalse(hasattr(self.carriage_checker, 'lines'))
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/style/checker.py ('k') | Tools/Scripts/webkitpy/style/checkers/watchlist.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698