Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: Tools/Scripts/webkitpy/common/watchlist/watchlist.py

Issue 17639006: Remove committer list, bugzilla, watchlist code and transitive closure of stuff. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge on top of thakis' change in r153020 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 #
3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are
5 # met:
6 #
7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer
11 # in the documentation and/or other materials provided with the
12 # distribution.
13 # * Neither the name of Google Inc. nor the names of its
14 # contributors may be used to endorse or promote products derived from
15 # this software without specific prior written permission.
16 #
17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28
29 from webkitpy.common.checkout.diff_parser import DiffParser
30
31
32 class WatchList(object):
33 def __init__(self):
34 self.definitions = {}
35 self.cc_rules = set()
36 self.message_rules = set()
37
38 def find_matching_definitions(self, diff):
39 matching_definitions = set()
40 patch_files = DiffParser(diff.splitlines()).files
41
42 for path, diff_file in patch_files.iteritems():
43 for definition in self.definitions:
44 # If a definition has already matched, there is no need to proce ss it.
45 if definition in matching_definitions:
46 continue
47
48 # See if the definition matches within one file.
49 for pattern in self.definitions[definition]:
50 if not pattern.match(path, diff_file.lines):
51 break
52 else:
53 matching_definitions.add(definition)
54 return matching_definitions
55
56 def _determine_instructions(self, matching_definitions, rules):
57 instructions = set()
58 for rule in rules:
59 if rule.match(matching_definitions):
60 instructions.update(rule.instructions())
61 # Sort the results to make the order deterministic (for consistency and easier testing).
62 return sorted(instructions)
63
64 def determine_cc_list(self, matching_definitions):
65 return self._determine_instructions(matching_definitions, self.cc_rules)
66
67 def determine_messages(self, matching_definitions):
68 return self._determine_instructions(matching_definitions, self.message_r ules)
69
70 def determine_cc_and_messages(self, diff):
71 definitions = self.find_matching_definitions(diff)
72 return {
73 'cc_list': self.determine_cc_list(definitions),
74 'messages': self.determine_messages(definitions),
75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698