Remove unused attachChildrenLazily method and make attach/detachChildren private

Remove unused attachChildrenLazily method and make attach/detachChildren private

No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.

In doing this I realized that attachChildrenLazily is not used and can be removed.

I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152841

[Hajime Morrita, 2013-06-21 00:10:39]

lgtm.

There was a reason why we did this.
But I don't remember what it was, and if the tests PASS, it'd be no longer the
case.

[commit-bot: I haz the power, 2013-06-21 00:10:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/17512006/1

[commit-bot: I haz the power, 2013-06-21 01:20:42]

Change committed as 152841