Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: Source/core/dom/ContainerNode.h

Issue 17512006: Remove unused attachChildrenLazily method and make attach/detachChildren private (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContainerNode.h
diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h
index 1af89093e81fbf3bd9dd8d3321511b5229443d47..28dea402f4a5ff20e07055e35e504bf60f6a3726 100644
--- a/Source/core/dom/ContainerNode.h
+++ b/Source/core/dom/ContainerNode.h
@@ -127,11 +127,6 @@ public:
// node that is of the type CDATA_SECTION_NODE, TEXT_NODE or COMMENT_NODE has changed its value.
virtual void childrenChanged(bool createdByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
- void attachChildren(const AttachContext& = AttachContext());
- void attachChildrenLazily();
- void detachChildren(const AttachContext& = AttachContext());
- void detachChildrenIfNeeded(const AttachContext& = AttachContext());
-
void disconnectDescendantFrames();
virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const { return true; }
@@ -158,6 +153,9 @@ private:
void removeBetween(Node* previousChild, Node* nextChild, Node* oldChild);
void insertBeforeCommon(Node* nextChild, Node* oldChild);
+ void attachChildren(const AttachContext& = AttachContext());
+ void detachChildren(const AttachContext& = AttachContext());
+
static void dispatchPostAttachCallbacks();
void suspendPostAttachCallbacks();
@@ -208,24 +206,6 @@ inline void ContainerNode::attachChildren(const AttachContext& context)
}
}
-inline void ContainerNode::attachChildrenLazily()
-{
- for (Node* child = firstChild(); child; child = child->nextSibling())
- if (!child->attached())
- child->lazyAttach();
-}
-
-inline void ContainerNode::detachChildrenIfNeeded(const AttachContext& context)
-{
- AttachContext childrenContext(context);
- childrenContext.resolvedStyle = 0;
-
- for (Node* child = firstChild(); child; child = child->nextSibling()) {
- if (child->attached())
- child->detach(childrenContext);
- }
-}
-
inline void ContainerNode::detachChildren(const AttachContext& context)
{
AttachContext childrenContext(context);
« no previous file with comments | « no previous file | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698